Privatemsg: The road to Damascus

could this list of items be added into the release notes for head? seems like a more logical place to track this for users of head who may not see this thread (at least for a month or two while these are hammered on)?
http://drupal.org/node/94379

@nbz and otheres - would integration with rules be considered paramount at this point? it would appear that there is currently no way to receive "off site" notifications of new private messages (this is one of the things that is considered a major driver in terms of community site use, which is where PM is typically used to facilitate user interactions) - seems that tying to subscriptions (versus the more robust notifications) may make less sense in d6 - and in fact, rules integration would be the most logical route (remove the other module dependencies completely, rules is powerful stuff)

Short help-guide for people willing to help:

This should not be done on production sites (unless you really know what you are doing), you should know how to apply patches but not necessarly how to code.

1: Download the latest HEAD version
2: Test it out, if you find bugs, look if there is already a open bug, if not, open a new one.
3: Download the latest patch from a issue in 'patch needs review' state (http://drupal.org/project/issues?projects=3279&versions=94379&states=8&p...), apply it and test it
4: If everything works, set the state to reviewed & tested by the community
5: If it does not work or if you have an idea to extend the patch add it to the issue.
6. Repeat ;)

Subscribe

i could test the BETA on my production as long as its UI not too bad and not too different from 5.3 version

is there support yet for offsite notifications or is that still on the todo? it's a bit unclear from the project page since this thread is a tad more current...

I would say the current target is to provide a generic interface/API to (re-)act on private messages, see #288183: Provide api function for other modules to send messages.. Then, we could have a simple submodule for sending notification mails. Or provide integration with Rules, Notifications, in other submodules if someone needs more configuration options or configurable email text's and so on.

@nbz - thanks for the answer!
@berdir - good idea. for example, some folks may want to truncate outgoing private messages to X characters (aka 'dating site' style to push users to log back in but with enough to see a snippet) - or users may want messages to go to a different email from registration, etc...or may want them daily versus instant, etc..or admin may want to push to cron, etc...(mail queue would be a wonderful integration prospect) - man, i wish i could write code! :(

Is it possible to make a new "road to damascus", where the user can see what is done and what are you planning to do and in which steps do you want to do it? I think michelle do it very good with the advanced forum: #326461: Release Plan. In the moment i have no idea where i can help testing a function. The most patches doesn't work with the current releases of privatemsg.

I needed the feature of emailing users that they have new messages. So I went ahead and implemented a hook in the pm_send() function. This way, any other module can act on the message that is being sent.

I've attached the patch. Do you think this would work as a simple implementation?

@nadavoid very good approach. this is excatly how i wanted to do it. however with 1 minor change. i would prefer to have different hooks rather than single hook with multiple $op.

drupal core is moving away from the $op implementation in favor of a standard hook_something_$op()

@litwol, thanks for the feedback. I definitely want to keep in line with how drupal core is going.

What would you think about something like this? If it's good, I'll submit a real patch.

$emailing = module_invoke_all('privatemsg_pm_send', $message);

and

function hook_privatemsg_pm_send($message) {
}

@nadavoid lets open a dedicated issue about this.

i think the best way to approach this would be to copy how user.module does it.

/**
 * Invokes hook_user() in every module.
 *
 * We cannot use module_invoke() for this, because the arguments need to
 * be passed by reference.
 */
function user_module_invoke($type, &$array, &$user, $category = NULL) {
  foreach (module_implements('user_' . $type) as $module) {
    $function = $module . '_user_' . $type;
    $function($array, $user, $category);
  }
}

user_module_invoke('insert', $edit, $user, $category);

New roadmap is at #372201: Roadmap for official 1.0 release