Left over from an api change

Needs tests still... which I need to learn how to write.

CommentFileSizeAuthor
#12 taxonomy_filter_test.324432_2.patch2.66 KBkirill.volkov
#11 taxonomy_filter_test.324432_1.patch2.66 KBkirill.volkov
#6 taxonomy_filter_test.324432.patch2.72 KBsirkitree
#3 taxonomy_filter_test.324432.patch2.67 KBsirkitree
#1 term_load_2.patch3.92 KBalpritt
term_load.patch738 bytesalpritt

Comments

alpritt’s picture

alpritt commented
Status: Needs work » Needs review
StatusFileSize
new term_load_2.patch3.92 KB

Now with tests.

Status: Needs review » Needs work

The last submitted patch failed testing.

sirkitree’s picture

sirkitree commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy_filter_test.324432.patch2.67 KB

try this one.

Status: Needs review » Needs work

The last submitted patch failed testing.

sirkitree’s picture

sirkitree commented

Hrm. not sure why this failed to apply. It's a cvs diff -up on HEAD... what am I doing wrong?

sirkitree’s picture

sirkitree commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy_filter_test.324432.patch2.72 KB

ah, didn't diff from my drupal root.

cburschka’s picture

cburschka
they
commented
Status: Needs review » Needs work

Shouldn't you still be diffing node.admin.inc? As it is, you're adding a test, but not the fix it tests for.

And if testbot passes this patch without that fix, does that imply that the test doesn't do the job, or does testbot just not run tests newly added by the patch?

alpritt’s picture

alpritt commented
Status: Needs work » Needs review

@7: CVS tells me it has been fixed elsewhere (#355787: Notice at admin/content/node when using a taxonomy filter), so we only need the tests. I've not reviewed beyond that.

cburschka’s picture

cburschka
they
commented
Title: taxonomy filter broken on admin/content/node » Test for taxonomy filter on admin/content/node

In that case, the title should reflect this.

mikejoconnor’s picture

mikejoconnor commented
Status: Needs review » Needs work

On line 35 you are logging in as $this->admin_user, however the setup function logs you in as the same user. I think you can remove $this->drupalLogin($this->admin_user) on line 36 of the patch.

kirill.volkov’s picture

kirill.volkov commented
Status: Needs work » Needs review
StatusFileSize
new taxonomy_filter_test.324432_1.patch2.66 KB

Here is the patch from #6 fixed as suggested by #10.

kirill.volkov’s picture

kirill.volkov commented
Status: Needs review » Needs work
StatusFileSize
new taxonomy_filter_test.324432_2.patch2.66 KB

Some internals have changed since that previous patch was written.

Here's a version which is close to working, but the vocabulary now needs to be attached to the content type by way of the field API.

The code in profiles/standard/standard.install does something very similar, so that could be appropriated to finish this up.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.