Improve email formatting & log to watchdog

This comment is to make public my invitation to xurizaemon to be my comaintainer of this module. This is to comply with all the formal requirements of applying for a CVS account under such circumstances.

Wierd, how come I can't just set this to "Ready to be commited"?

I wrote this module before coder.module became popular, and before I understood the importance of code style conformance, so take this comment with a grain of salt since civicrm_error.module does not pass the Drupal coding standards. But we should probably endeavor to not make things any worse.

There are several coding syntax issues with your patch:
* Comments without a trailing period.
* No space between trailing colon and the previous character.
* Missing "break;" in your final case.
* nested arrays should look like (note the indenting):

  $var = array(
    'foo' => 1,
    'bar' => 'one',
    'baz' => array(
      'yar' => TRUE,
    ),
  );

cnw

Wow, if we want to do a full audit of the code format that's great too. We probably shouldn't try to put anything else in this patch though ;-)

A few things I noticed. It looks like your last patch does not include the work in your previous patches. Not sure how you managed that. Perhaps with svn diff and you had already committed your previous change to svn? Try cvs diff -ur BASE to get all your changes diffed against the version that you checked out of CVS.

Also you shouldn't use {} on civicrm tables since if they get prefixed things will break badly.

Other than that it looks pretty good.