This patch just fixes the numerous spacing issues in this module.
- It leaves the user docs in README.txt and moves the rest to CHANGELOG.txt
- It removes all the tabs
- It removes all trailing spaces from the end of lines.
- It makes the indentation conistent.
- It removes the un-recommended VERSION from the .info files.
- It uses single quotes instead of double quotes where it makes sense.
- It uses double quotes to prevent escaping single quotes.
- It removes some backticks (`) from some SQL queries. Drupal core doesn't use them. (And neither does Drupal core have spaces in SQL column names; but that will have to wait for another patch.)
| Comment | File | Size | Author |
|---|---|---|---|
| code-cleanup.patch | 227.79 KB | johnalbin |
Comments
Comment #1
johnalbinNormally, I wouldn't be so nitpicky for contrib modules, but since the idea is to get this into core, the sooner its cleaned up, the better. :-)
Comment #2
tonyn commentedGotcha. I'm working with this and
http://drupal.org/node/324836 to try to make both these things work.
Do you need commit access? You are creator of Zen so probably can help make this module Zen-friendly and such.
Tony
Comment #3
tonyn commentedCommitted. (Is this the tag we use for commits? Or is it closed? Or Fixed?)
Comment #4
johnalbin:-)
http://drupal.org/node/156119 shows the proper status to use.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.