I'm looking to do a lookup for a non-cached item on a geonamesId using the get webservice. Since it doesn't exist, I'm trying my hand at implementing it.

  $config['get'] = array(
      'service_name'        => 'get',
      'service_full_name'   => 'Get using geonameId',
      'description'         => 'Find Geoname using geonameId',
      'service_path'        => 'get',
      'credit_cost'         => 1,
      'result_cache_prefix' => 'getres:',
      'data_cache_prefix'   => 'getdat:',
      'allowed_parameters'  => array(
        'geonameid' => 'geonameId',
        'style' => 'style'
      ),
      'columns' => array(
        'name',
        'lat',
        'long',
        'geonameId',
        'countryCode',
      ),
    );

The while the webservice returns data, the Geonames module does not correctly parse the XML result. I suspect in part it has to do with totalResultsCount not returned in the XML for the get service. The XML traversal appears to be ok, though I haven't tested it explicitly against the result set with one less parent node.

CommentFileSizeAuthor
#5 geonames_get.patch2.53 KBAnonymous (not verified)

Comments

aurevo1r’s picture

aurevo1r commented

Also, here's the result of a get query.

stdClass Object
(
    [standalone] => no
    [total_results_count] => 0
    [service] => get
    [request] => Array
        (
            [url] => http://ws.geonames.org/get?geonameId=4275586&style=FULL
            [bytes] => 664
            [cached] => result
            [seconds] => 0.00544309616089
        )

    [query] => Array
        (
            [geonameid] => 4275586
            [style] => full
        )

)
2xe’s picture

2xe commented

Hi,

The 'get' service is structured diffently than the others -- so the current parser won't be able to produce the proper output. I have actually implemented this service myself, but not tested it properly yet. Here's a custom parser for the get service;

/**
 * Parser for the Get service
 */
function geonames_parse_get_xml($data) {
  $xml = new SimpleXMLElement($data);
  foreach ($xml->children() as $key => $entry) {
    $k = (string) strtolower($key);
    $v = (string) $entry;
    if ($key != 'status') {
      $fields[$k] = $v;
    }
    else {
      $result->status['message'] = (string) $xml->status['message'];
      $result->status['value']   = (string) $xml->status['value'];
    }
  }
  if (!empty($fields)) {
    $result->results[] = $fields;
    $result->total_results_count = 1;
  }    
  else {
    $result->total_results_count = 0;
  }
  return $result;        
}

My service config looks like this:

  $config['get'] = array(
    'service_name'        => 'get',
    'service_full_name'   => 'Get',
    'description'         => 'Retrieve GeoNames record by geonameid',
    'service_path'        => 'get',
    'credit_cost'         => 1,
    'result_cache_prefix' => 'gres:',
    'data_cache_prefix'   => 'gdat:',
    'allowed_parameters'  => array(
      'geonameid' => 'geonameId',
      'lang'      => 'lang',
    ),
    'columns' => array(
      'geoname',
    ),
  );

..and you will have to trigger the proper parser - change

    $result = geonames_parse_xml($data, $fields);

to

    $result = ($service == 'get') ? geonames_parse_get_xml($data) : geonames_parse_xml($data, $fields);

I'm unsure if this is complete -- I've just copied and pasted from my dev-version. (I wasn't aware of the style parameter.. just add it like you did so any queries using this won't fail.)....

Have a nice day!

Sero

2xe’s picture

2xe commented
Assigned: Unassigned » 2xe
Category: bug » feature
Status: Active » Needs work
aurevo1r’s picture

aurevo1r commented

Thanks. I'll try it out and report any issues I have with the patch and if I can, implement a fix.

Anonymous’s picture

Anonymous (not verified) commented
Title: http://ws.geonames.org/get webservice implementation not parsing » 'Get' webservice implementation
Version: 6.x-1.1 » 6.x-1.x-dev
Assigned: 2xe » Unassigned
Status: Needs work » Needs review
StatusFileSize
new geonames_get.patch2.53 KB

Here's a patch of SeroSero's changes. Seems to work alright, though haven't tested everything...

lyricnz’s picture

lyricnz commented
Status: Needs review » Fixed

Fixed in http://drupal.org/cvs?commit=262756

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.