Hi, I know several people who want to use the video module with Drupal 4.6. It seems that you don't want to maintain the 4.6 branch, but that'd be really helpful for lots of people.

Here's a patch against the current HEAD which makes it work with Drupal 4.6. If you want me to, I can keep the 4.6 branch up-to-date with HEAD development by backporting the needed changes... Please let me know.

HTH, Uwe.

CommentFileSizeAuthor
#2 video.4.6.module58.39 KBLukeLast
video46.patch6.45 KBUwe Hermann

Comments

B-Dot’s picture

Hi Uwe,

I am one of those people who would very much like to use the latest version of the video module (with Luke's excellent enhancements) with my Drupal 4.6 installation, so I was very excited to see that you've provided a version of the code to achieve this.

Am I correct in thinking that I must have CVS installed as part of Drupal in order to use your patch? I'm totally new to this level of Drupal and would appreciate any pointers. I did find this page - http://drupal.org/node/28245 - but I'll admit it is a bit intimidating for a newbie. I'm unsure of whether I should be specifiying the 4.6.1 branch when I check things out, as detailed towards the bottom of that page. Any help you (or anyone else) could offer would be most appreciated.

Barnaby

LukeLast’s picture

StatusFileSize
new58.39 KB

I think that would be great if you want to set up and maintain a 4.6 branch, and I'm sure fax8 would be OK with it. I could not figure out how to update the branch with tortoiseCVS but I attached a 4.6 version of the module.

B-Dot’s picture

Hi Luke,

Thanks for all your fantastic work on this module - when I saw what you had done at http://www.ppixel.com it was like manna from heaven.

I downloaded the video.4.6.module you just posted, but I'm getting a white screen with the following error when I hit my server:

Parse error: parse error in c:\appserv\www\drupal\modules\video.module on line 74

I have updated my DB with the changes. Is there anything else I need to do to get this to work in 4.6 that you can think of?

Barnaby

Uwe Hermann’s picture

Did you copy+paste the module contents? You cannot simply download it, it's really a bunch of HTML, you need the text only... How exactly did you upgrade the database? You need the version from 4.7. Do you have any whitespace at the beginning or end of the module file? Does the web server have correct permissions to read the file (_all_ module files for that matter)?

B-Dot’s picture

I cut and pasted the module text from the browser into BBEdit, saved as plain text and uploaded. The formatting was preserved, the colour coding appeared properly and there is no leading or trailing whitespace.

I am running Drupal 4.6.1, 2005-06-01, no CVS.

I started yesterday with the version that is designed for version 4.7 and the CVS but ran into problems because I soon realized that I was not running either of those. Today I tried using the version on this page that Luke posted - video.4.6.module.

I updated the database the usual way - using PHPMyAdmin, I selected the Video table and ran a query that was comprised of the upgrade SQL text statements that are in the top comment section of the new module. It executed succesfully.

Is my problem perhaps that the SQL update statements that I ran are for the 4.7/CVS version? Or are the DB table structure changes the same for both?

The error is being generated on the first line after the comment block, which does seem like there is something wrong with syntax or formatting perhaps. I don't think that this is an issue of file permissions...

fax8’s picture

This is a useful patch but I don't think could be a good idea to mark it as 4.6 version.
I believe that a heavy changes into functionality, db tables, interface can easealy make
users confused...

A lot of drupal users still don't know about modules versions, they simply expect one version
for each drupal branch.. I don't want to confuse our users.
so I think that upgrading current 4.6 video module version is not a good idea.

Users looking for more video functions for 4.6 can still apply this patch if they need it.

This is my opinion.

What do you guys think about this?

Fabio

B-Dot’s picture

Just a note to say that I got the new video module working on 4.6.1. Not quite sure what was wrong, but I deleted everything to do with the video module including the DB table and started fresh, and everything is now working! Thank you all for your help.

Sorry to ask a further newbie question, but I was wondering if someone could now point me in the direction of how exactly one goes about theming this module/function so that the new custom fields show up, i.e. preview image, title, description type fields etc... like Luke has on his site at http://www.ppixel.com/index.php?q=node/18

Also thought I'd mention that I'm having the same Quicktime problem in Safari that is mentioned here http://drupal.org/node/29299

Weirdly, these Quicktimes play fine on Windows in IE. I think this may actually be an Apple issue....

Thanks again,

Barnaby

Uwe Hermann’s picture

Regarding #6: I don't think it's too confusing for users, they still have a 4.6 tarball they can download and a 4.7 tarball if they run Drupal 4.7. They would have to upgrade, though, that might be a bigger problem...

If you don't want to maintain a 4.6 port, I'll just keep this patch up-to-date here so that interested parties can get it...

Uwe.

fax8’s picture

perfect Uwe!

Feel free to discuss my ideas about this backport here
if you feel that is not a good idea.

Fabio

ron collins’s picture

after reading the above, i'm still not sure i understand. if i am running 4.6.x, i need to install the 4.7 (cvs?) version of video.module and the 4.7 version of the video table and then run the patch against the module?

Uwe Hermann’s picture

Exactly. If you already installed the database tables of the 4.6 version, I suggest you remove them or upgrade.

Uwe Hermann’s picture

Status: Needs review » Reviewed & tested by the community

The 4.6 backport of video module is now available from my sandbox: http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/uwe/. I will keep that patch up-to-date with further video module development...

agentpt’s picture

As a noobie and not very technically advanced guy I have figured out how to apply this patch and have posted a 10 step guide here http://drupal.org/node/14231. Hope this will help some people

fax8’s picture

the right link is http://drupal.org/node/35429.

Fabio

Uwe Hermann’s picture

An already patched version of the video module is now available from http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/sandbox/uw..., you can use that as is (without any patching).

HTH, Uwe.

canen’s picture

Uwe,

Could a link to this be placed on the video module page? A backport to 4.6 is mentioned but no link given.

Thanks.

shixi’s picture

Version: master » 4.6.x-1.x-dev

Where can i get the module video_image.module for 4.6?
Thx
--
xshi @ mae.cuhk.edu.hk

vm’s picture

Version: 4.6.x-1.x-dev » master

No need to change the version.

you have to use the patch files found in the beginning of this issue. Please read the ENTIRE issue. or use the actual .module file in #15

shixi’s picture

Firstly, I installed video-4.7.x-1.0.tar.gz
Then I used the video.module in #15 to replace the original video.module.

It works, but the video_image module seems not work, though I checked it.

I put a video here: http://arl.mae.cuhk.edu.hk/node/568
I can't see a image in the view mode.

--
Xi SHI

fax8’s picture

Version: master » 4.6.x-1.x-dev
Status: Reviewed & tested by the community » Closed (won't fix)

old stuff