Patch (to be ported)
Project:
Relevant Content
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
23 Oct 2008 at 08:52 UTC
Updated:
28 Dec 2022 at 14:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nicholasthompsonWhat are you using for your multilingual "stuff"... i18n?
Comment #2
nogat commentedyep, i18n
Comment #3
nicholasthompsonI'll have to take a look at how i18n groups the nodes together once you translate a node... Eg, if node 10 is the english node and you translate it to french and end up with node 15 as the french one... How does drupal know that node 10 and 15 are difference language versions of the same node?
Also - would you want the language limited to that of the current node? For example... You read an english node on cooking ham and Relevant Content finds some other nodes including "cooking beef", "cooking chicken" and "cooking ham & chicken (in french)"... Technically the french hame & chicken node is more relevant than the cooking beef one (depending on taxonomy) however its not in a matching language.
Any thoughts?
Comment #4
nogat commentedi18n has its own mechanism to select which node types to show the user. possible content selection modes are:
- Only current language and no language
- Only current and default languages and no language
- Only default language and no language
- Only current language
- All content. No language conditions apply
i think best choice is to follow same approach with relevant content as well. maybe some lines of code could be reused.
also i think multilanguage websites are multilanguage becouse we suppose most of the users to speak only 1 language, otherwise we could do it single language, so i don't see any reason to show a related node in another language, it will repesent noise for most of the users.
thank you for the good job!
nogat
Comment #5
nicholasthompsonI'll have to find time to research this more. To be honest, I have VERY little time on my hands and I personally never make multilingual sites so wont have a chance to develop this feature under the pretence of work either.
I'm perfectly happy to help review patches if anyone wants to help out though!
Comment #6
realOFF commentedSame here. Subscribing.
Comment #7
binhcan commentedIt's 6.x now and it's still not obeying the mutlilingual feature of i18n module. Still displaying cross-language nodes causing duplicate content on my site Classical Chinese Furniture
Comment #8
gantenx commentedHi,
I've patched 6.x-1.4 version so that the module will respect node's language and will only display relevant nodes in that language and language neutral nodes. Similar approach with Similar By Terms module.
Comment #9
nicholasthompsonLooks ready to be committed - although I think I'll add the language argument after the existing limit argument - that way the "API"-ness of the function doesn't change.
Comment #10
gantenx commentedI think the limit argument is always good at last place. But this will sacrifice the API-ness of the function. How do you think?
Comment #11
nicholasthompsonThis has been commited to D6 (dev), needs porting...
Comment #12
william.lai commented#8 patch seem not work with latest version of relevant content.
Updated #8 patch for 6.x-1.5 and attached.
Comment #13
ohadgolan commentedAny updated for 6.26, having the same issue...
Comment #14
nicholasthompsonI need to test / port this work to D7 (and eventually D8). When I worked on this in 2011, I'd not really experienced a lot of multilingual sites, but I have now :) I have a good idea how they work and how this module would not work well with them.
Thanks for raising this bug/feature request!
Comment #15
nicholasthompsonMoving to 1.x - Definitely need to confirm this!