The theming function theme_uc_product_sell_price produces a SPAN element which then sits in a node's HTML output alongside block-level elements such as DIVs.
This isn't good practice for HTML and should be changed to a DIV.

Comments

rszrama’s picture

rszrama commented

Are you referring to the HTML for a product node's teaser? Can you test the fix to make sure it doesn't affect the teaser unexpectedly?

rszrama’s picture

rszrama commented
Status: Active » Postponed (maintainer needs more info)
joachim’s picture

joachim commented
Status: Postponed (maintainer needs more info) » Active

Here's a product node in teaser, as currently generated:

<div class="content">
    <div class="display_price">$20.00</div><p>text</p>
<p>more text.</p>
<span class="sell_price">$20.00</span>
<div class="add_to_cart">
[ the add to cart form here]
</div>
</div>

With that SPAN changed to DIV, the display of the node in teaser (in Garland theme) is identical to the eye, just cleaner semantically.

Island Usurper’s picture

Island Usurper commented
Status: Active » Fixed

I guess I didn't realize that the product's description would be wrapped in <p> tags, so <span> made sense to me. While it's not a technical violation (it validates after all), I see what you're saying about semantic markup.

Fixed for 1.6 and 2.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.