The menu built by taxonomy_dhtl doesn't behave like the regular Drupal menus:

- it has a &nbsp; - prefix instead of being wrapped with <li>;
- it isn't marked as selected when clicked (see above);

It would be great if the taxonomy_context block building routines were recycled for this module too.

CommentFileSizeAuthor
#4 taxonomy_dhtml.module_3.patch1.96 KBdavid lesieur
#3 taxonomy_dhtml.module_2.patch1.96 KBdavid lesieur
#2 taxonomy_dhtml.module_1.patch1.89 KBdavid lesieur

Comments

moshe weitzman’s picture

moshe weitzman commented

patches on this would be accepted. Note this issue has been open for years now: http://drupal.org/node/2039

david lesieur’s picture

david lesieur commented
Version: 4.6.x-1.x-dev » master
Status: Active » Needs review
StatusFileSize
new taxonomy_dhtml.module_1.patch1.89 KB

Here is a patch for this.

This patch requires this other one.

david lesieur’s picture

david lesieur commented
StatusFileSize
new taxonomy_dhtml.module_2.patch1.96 KB

Updated to skip terms with zero node count.

Still requires this other patch.

david lesieur’s picture

david lesieur commented
StatusFileSize
new taxonomy_dhtml.module_3.patch1.96 KB

The other patch has been updated, so I updated this one as well.

mathieu’s picture

mathieu commented
Status: Needs review » Needs work

I tested out this patch, but it won't apply anymore as taxonomy_dhtml needs to be upgraded to head. I started to work on this, but there is a lot to be done. I can send what I did to anyone interested, but David tells me that this module is getting forgotten as views.module is gaining popularity.

Are there still people interested in this?

meba’s picture

meba commented
Status: Needs work » Fixed

Fixed in 5.x

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)