An extra comma appears at the end of the displayed node term(s). The patch removes this extra comma. It's pretty straightforward.

Comments

jwolf’s picture

Assigned: Unassigned » jwolf
jwolf’s picture

Priority: Normal » Critical
GoofyX’s picture

Version: 6.x-1.2 » 6.x-1.3

I've done some research over this. I think that there is a logic error inside template.php. Line 340 retrieves all vocabularies for a content type. Let's say that the blog type has vocabularies a, b, and c. In the foreach loop through lines 342-357, for each vocabulary the list of terms associated for this vocabulary and the particular node is retrieved. Let's say that we retrieve terms x, y for vocabulary b. The if check at line 354 would return ', ', because the b vocabulary is not the last one in the list of vocabularies (remember, a, b, and c), although it's not associated with vocabulary c, so we should get a '' here. What we need is to check if the vocabulary is the last of the ones that this particular node is associated to and not to all of the vocabularies.

I currently cannot propose a solution, as it's 2:11am and I must go to bed. :-)

jwolf’s picture

Status: Needs review » Fixed

ok. This should be fixed now.

You were right about the error in logic and it's been fixed.

Patches are attached. Patch against 6.x-1.3
Changes have been made and are also available in the latest dev snapshot.

Thnx for taking the time to find this; it was pretty obscure.

jwolf’s picture

StatusFileSize
new1.51 KB
new4.51 KB

Here are the patches..

GoofyX’s picture

Thanks. Latest dev version works fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.