Closed (fixed)
Project:
Pagination (Node)
Version:
6.x-1.3
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Oct 2008 at 00:07 UTC
Updated:
14 Nov 2008 at 19:08 UTC
Before I discovered the prob between pagination and view reference (seem to be working well together now) I had putquite a lot of effort into styling div#toc in pagination.css .
Now that the conflict with view reference is gone, I've turned pagination back on and it doesn't seem to be using pagination.css at all.
Firebug tells me that div#toc is being styled by 46dd94fc9675baeeeac61e4c47ea4476.css which looks to be a cached copy of the book module's style sheet.
I really want to regain styling control of the Pagination TOC.
Any ideas?
Comments
Comment #1
mundanity commentedHi there,
Glad to hear it's working out well with views, thanks for the update on that. You can clear your cache by going to Admin -> Performance -> (Clear Cached Data). This will let Drupal rebuild any cached information, at which point it'll pick up your fresh CSS definitions.
Comment #2
austintnacious commentedSo I had caching and CSS compression turned on, sorry for rattling your cage unnecessarily.
Turned it off and bingo, my styling is back.
On to the feature request. . .
Any chance you'll add a "current" class to the list items in ul.toc-list.
It would be cool to be able to style the inactive toc listing for the page being viewed.
Of course I could it by styling all the other anchors within the list but it seems better to me to style the odd one out, if that makes sense.
Also, I note you're giving the anchors within the toc list
class="active"and I wonder if that's a good idea.I don't know that it's causing any problems but there's a chance it could or could lead to confusion with the CSS psuedo class
:active.I'd be more inclined to think that types like me would prefer to see something like
class="pagination-toc-link". that way I'm pretty confident the class is unique, will not conflict with predefined CSS psuedo classes and it declares which module is spitting out the CSS and HTML (SUPER helpful for people like me).Comment #3
austintnacious commentedsorry fogot to change category
Comment #4
mundanity commentedHey,
No problem, I can add the "current" class, I'll add that into dev, and post the patch here. The "active" class is set by drupal unfortunately, and I haven't been able to find a way around taking it off. The issue is that links that are themed through drupal are all assumed to be the same (and thus are tagged "active"). The check that drupal uses is pretty stringent, and I haven't found a way around it beyond modifying core code. It's on my list of "things I'd like to fix but may have to rely on a drupal core patch".
Comment #5
mundanity commentedHi there,
I've updated the dev with the "current" class addition, the patch diff is here. Basically you can just change it manually yourself (the changes are in pagination.module), by adding the green line in the patch, and changing the yellow line at the bottom. The dev versions take about 12 hours to recompile, if you wish to wait for that.
Comment #6
mundanity commented