Mark issues as CNW when most recent patch has failed testing
boombatower - October 24, 2008 - 05:52
| Project: | Project issue file testing |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
After results come back if it meets conditions then mark issue as CNW.
I came up with the following comments when I wrote my code:
<?php
$self = parse_url(url('', NULL, NULL, TRUE));
$result = url(variable_get('pifr_test_master_url', '') . 'pifr/file/' . $self['host'] . '/' . $file['filename']);
$changes = array();
$changes['nid'] = $file['nid'];
$changes['sid'] = variable_get('pifr_report_fail_status', '');
if ($file['cid']) {
$comment = url('node/' . $file['nid'], NULL, 'comment-' . $file['cid']);
$changes['comment'] = t('The file <a href="@comment">@name</a> failed testing.' .
' For more information please see the <a href="@results">detailed results</a>.',
array('@name' => $file['filename'], '@comment' => $comment, '@results' => $result));
}
else {
$changes['comment'] = t('The file @name in the original post failed testing.' .
' For more information please see the <a href="@results">detailed results</a>.',
array('@name' => $file['filename'], '!post' => $post, '@results' => $result));
}
project_issue_add_followup($changes);
?>
#1
Related interface.
#2
i don't think your .png file is the result reporting picture ;)
#3
That is just what I had for selected what status to set the issue to on a fail. The comments are in the code.
#4
i'm postponing this for now. the auto status changing based on patch testing results has been a big headache every time we've tried it. i want to see the testing framework running smoothly for awhile before i install this feature in pift.
#5
this is now officially waiting on #326184: review test results for accuracy
#6
http://drupal.org/node/326184#comment-1080349
#7
discussing this feature a bit more w/ chx, we agreed that the most straightforward approach for the content of the comment would be something like:
The most recent patch failed testing.
'failed testing' would be an internal page link to the test result display table for the patch.
#8
this is now held up by http://drupal.org/node/327238
the reason is simple: without realtime knowledge of what files PIFT is sending for testing, it becomes much more difficult and messy to clearly determine the 'last' testable file posted to the issue.
#9
It's rare that I *subscribe* to issues, but this is one.
#10
http://drupal.org/node/327238#comment-1089594
#11
The messages above should provide a good starting point, or just use em.
#12
http://drupal.org/node/326425 really needs to be finalized before we deploy anything in this patch on drupal.org, so if anybody can help there, i'd appreciate it.
#13
attached patch has been committed to 5.x and HEAD, and pretty heavily tested on a local install.
#14
Automatically closed -- issue fixed for two weeks with no activity.