Closed (fixed)
Project:
Menu Trails
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Oct 2008 at 12:30 UTC
Updated:
8 Nov 2008 at 18:41 UTC
Jump to comment: Most recent file
a) coder_format is your friend.
b) Also applying for CVS access hereby. :)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | menutrails-DRUPAL-5.patch | 12.93 KB | sun |
| menutrails-DRUPAL-6--1.cleanup.patch | 13.7 KB | sun | |
| menutrails-HEAD.cleanup.patch | 11.66 KB | sun |
Comments
Comment #1
joshk commentedNicely done.
Comment #2
joshk commentedGranted CVS; go ahead and commit!
Comment #3
sunDone.
I've taken the freedom to clean-up 5.x, too. Patch attached.
Another important thing to deal with in all co-maintained projects is to have a proper CHANGELOG.txt, which I've added to all branches now. The common best practice is to create project issues for all changes, post patches for review, and finally just write a commit message into the changelog, copy that as commit message, and commit. Can we agree on this procedure?
Aside from that, I've seen that all of the branches have different contents currently. While there was a commit message about HEAD being 7.x compatible, it seems like you did not update it anymore. Can we just overwrite everything in HEAD with the contents of DRUPAL-6--1 for now?
Lastly, I've discovered that albeit there was never an official release for 5.x, it is used on approx. 500 Drupal sites. Anyway, since the menu system changed dramatically between 5.x and 6.x, and our goal is to move the functionality of this module (or parts of it) into core ASAP, I'd like to suggest to leave 5.x "as is" and close all issues in the queue, which are not bug reports. We do not have to (and should not) mark it has unsupported, so users are free to use it, but let's focus on 6.x+ from now on. Thoughts?
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.