D6 buglets

moshe weitzman - October 24, 2008 - 18:23
Project:Book access
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Harry Slaughter
Status:closed
Description

I just had a quick read of the code. webchick's is hyping this module at http://groups.drupal.org/node/16134#comment-55161.

  • if ($node->type == 'book') {. huh? we only protect nodes of type=book? i must be missing something
  • cruft: "* Checks to see if maybe we're being disabled."
  • _book_access_restrict_options() - the second loop can be replaced by array_diff() I think.

#1

Harry Slaughter - January 21, 2009 - 05:53
Assigned to:moshe weitzman» Harry Slaughter

-> if ($node->type == 'book')

this is a relic of the D5 version of the module.

the D6 port was never properly completed or tested.

i'm going over the module right now to remedy that and will integrate this ticket.

tks moshe

#2

Harry Slaughter - January 26, 2009 - 19:36
Status:needs review» fixed

addressed in rc2

#3

System Message - February 9, 2009 - 19:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.