[DBTNG + simpletest] queryTemporary is broken and need simpletest test case

we pass on $options from queryTemporary, it's not defined, so we pass a NULL , so query dies at $options += ....

So there.

Followup -- made the function headers consistent with the rest of core and added a test.

Even more followup, detailed PHPdoc!

The problem over there is that your test does not test the temporary-ness of the queryTemporary.

Sniff.

Oh. Have not seen hswong3i's patch. However, his adds db_query_range comments to this issue -- that's a separate issue. Moves the test under admin -- nothing to do with admin. Also, his removes wrongly the prefixtables call -- we still need to prefix the tables in the SELECT -- the only thing not prefixed is the created temporary table. Adding "AS" to postgresql is, however a good idea, and MySQL works with it too so I moved those into mine.

AH! I now understand, query will prefix so we do not need to. Now. If both mysql and pgsql has the same queryTemporary code what's the point in providing in both?

A careful review of the mysql documentation reveals that it's a bad idea to use the heap engine (which should be TYPE=MEMORY anyways) because the resulting table size is limited by a setting leading to interesting bugs. As hswong3i rightly mentioned, other DBs do not support it anyways.

I cleaned up this issue from hswong3i comments and my frustrated remarks. Let's stay on topic.

What hswong3i never was able to communicate through is that the comments on db_query_temporary are copy-pasted from db_query_range thus are wrong. It's not trivial to see this from just looking at the patch as the preceding function is db_query_range.

Every class name in database_test.test is DatabaseSomeThingTestCase so I am moving "Test" to the end, just before Case, so that it's DatabaseQueryTemporaryTestCase instead of DatabaseTestQueryTemporaryCase.

After more discussion with hswong3i it came to me that deciding on whether to use the MEMORY engine or not, does not belong to this patch. With this, we are quite back to #10 with the following differences:

1. the copypasted comments are removed.
2. Engine=HEAP replaced with TYPE=MEMORY for MySQL
3. Engine=HEAP replaced with AS for pgsql
4. the test path is database_test_query_temporary
5. Fixed the multiline comment

Better @param $tablename documentation for db_query_temporary -- temporaryQuery and Drupal 6 had this text. (It's strange to be db_query_temporary and temporaryQuery -- not consitent -- but that's a followup).

Please credit hswong3i as quite some of the late changes are his. It's not impossible, after all, to work with him -- it's just incredibly hard because of language issues but now he is quite willing to make a compromise and not force an Oracle-focus on every patch. And quite some of his findings are valid and useful.

One minor change, in the module phpdoc you had a "tempory" other than that, we are good.