Method for disabling "remember-last-tab functionality"

txcrew - October 25, 2008 - 14:57
Project:Magic Tabs
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:yhager
Status:active
Description

Hi,

Unless I am missing something, is there a way I can Disable the "remember-last-tab functionality" for authenticated users? I would like to force default tabs for all users.

TIA
txcrew

#1

yhager - October 25, 2008 - 15:03
Assigned to:Anonymous» yhager

reasonable request - I was suspecting this behavior would not fit everyone..

I'll add it in on the next round of fixes (no more tiny-module-with-no-settings-scree for me..)

#2

txcrew - October 25, 2008 - 15:08

Thanks for the extremely fast reply.

For the time being, I just commented the changes as seen in the diff: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/magic_tabs/...

It seems to do the trick, but could that break anything else/affect performance?

txcrew

#3

yhager - October 25, 2008 - 15:32

‏Yes, I think it would work for you.

#4

gzbk - October 26, 2008 - 09:59

Hello,
Excuse-me by advance in case this remark may sounds out of nowhere, since I'm a complete newbe in Drupal.
I'm not sure if some settings screen will really fit everyone needs. Since this module already needs to write PHP code, I don't think it is really a big deal if we would have to set two more variables to configure Magic Tabs behaviour. IMHO, settings screens are mostly usefull when we can bring module users a end-to-end graphical system.

On my (future) site, for now I will use Magic Tabs only for one node type... but what if I wouldlike to use it for two or three different node types? It seems silly to me to select by default the third tab on node-type B page because you selected the third on node-type A one (given the two node types have no relations between them).
Therefore I think we should get a variable to give an internal name to tabs group (it could be append to the session vars name you are using). That would be for the first variable.

Then in a second time, like what was mentionned in this thread, for each tabs group we should be able to say wether we want the selected tab to be backed up or not. A simple boolean value, saved in the session vars, and letting Magic Tabs conditionally execute the code commented out by txcrew.

Just two variables to set for modules users, no settings screen for you, and far more functionalities for Magic Tabs ;) !

 
 

Drupal is a registered trademark of Dries Buytaert.