Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There is a string 'There are no existing vocabularies, you should !add one.' in the latest version of rules. For translation purposes, !add should be replaced by a simply link (a-html-tag), so it is obvious how to translate it (in other languages than english the string behind !add may have to be translated differently).
It's the same with 'There are no terms in the vocabulary, you should !add one.'
Could you tell me what 'none' in the string '- None selected -' refers to (node, rule, term, e.g.); I didn't find it in the user interface, yet? Generally I think that those strings should be replaced by something like 'No term selected' for translation purposes (in german there are at least 4 different translations for none depending on the context: keiner, keine, keines, kein)
Comments
Comment #1
fagot('- Please choose -') : t('- None selected -') is both referring to terms. As this stems from a function copied from drupal core, the strings should be in the core translation. I don't know if you have to translate it again? Anyway I've just removed t('- Please choose -') as for rules the last one fits better anyway.
@add:
According to http://api.drupal.org/api/function/t this is a wrong use of t(). I'll fix this.
hass already notified me of that :) -> If you are aware of more such badly embedded links please just tell me and I'll fix them.
Comment #2
amitaibufago,
Can you explain what was wrong - i'd like to learn as well ;)
Comment #3
fagoof course.. :) http://drupal.org/node/323436 might interest you too.
Read the paragraph starting with "When using t(), try to put entire sentences and strings in one t() call." at http://api.drupal.org/api/function/t.
And of course feel free to roll a patch.. ;)
Comment #4
FrankT commented...the strings with !add (see original post in this issue) are still in the dev version of 07-Nov-2008...
Comment #5
mitchell commentedI checked this out, and this issue still exists.
@rastatt@drupal.org: is this one you could make a patch for?
Comment #6
FrankT commentedSorry, I'm not really neither into drupal/php programming nor patching. My hint was just about translating the module.
For each string with an !add the questions are: Are there different things that are put into that variable? If no there should be just one string without that variable. If yes it should be programmatically split into several different strings without the variable (something like if/then).
Comment #7
fagoIt should be changed to follow the docs of t() - just manually create the link in t() and only add generate the !url with url() by using a replacement for it
Comment #8
fagonT
Comment #9
fagoI just went through and fixed all translation issues I was able to find. I also made sure all strings can be found by t(). Then I've regenerated all translation templates.