Closed (fixed)
Project:
Xstatistics
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
30 Sep 2005 at 10:29 UTC
Updated:
9 Feb 2006 at 20:01 UTC
Jump to comment: Most recent file
Well, as per title... I'm using a multiple site set up from one codebase. All file folders and tmp folders are different (not that it should make any difference here I guess?) Anyways, two sites work fine, but one site (and typically the more important one) displays this on the summary page:
description value
Total amount of external referrers today 53
Total amount of internal referrers today 101
Total amount of viewed nodes today
Total amount of viewed nodes all time
Total amount of viewed pages today 963
Total amount of hits today 963As you can see - two are blank and I'm not sure that the bottom two have changed at all since I installed the module yesterday... Note that I'm NOT SURE, so they might have :o)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | xstatistics_summary.diff | 3.09 KB | greggles |
| #2 | xstatistics.module.patch | 1.5 KB | Timotheos |
Comments
Comment #1
kbahey commentedIt certainly works for me.
I even refreshed the page several times, and verified that the counters are incremented.
So, it has to be a problem with your setup.
Try executing the SQL from phpmyadmin or mysql and see what happens.
Comment #2
Timotheos commentedThe reason this is happening is because 'count content views' is disabled. The totals are taken from the node_counter table so if this is empty then it will be blank. I've put a conditional statement around this and put a 'disabled' link to the admin/settings/statistics if it's off.
Tim
Comment #3
gregglesI just confirmed the problem as Timotheos described it as surfacing when "count content views" is turned off.
I tested the patch.
1) It didn't apply cleanly for me, so I created a new one.
2) In my test installation I had statistics turned off completely, so the link to admin/settings/statistics was somewhat confusing about what I was supposed to do there. In my scenario, a link to modules would be more appropriate.
I think it's a good idea to inform the user that they may need to do something different to enable these numbers, but I think the link lacks in describing the steps necessary to enable those counts in both my scenario and the general scenario. However, I think that it's more likely that the user has statistics enabled if they are downloading this module in the first place.
So, my solution is twofold:
1) add a comment to the INSTALL file that explains that "statistics" module must be turned on
2) expand on "disabled" to say "enable Count Content Views to see values"
I also removed the trailing ?> from the end of the file as recommended in the best practices. http://drupal.org/node/545
I tested this and it seems to work, but I'm not 100% sure in this case how to handle it.
Bèr - it would also be nice if you updated the install page to note that statistics is required and that "count content views" is recommended to get all values.
Comment #4
Timotheos commentedLooks good.
Comment #5
(not verified) commented