Add more functionality to menu item settings on node/*/edit pages

Any chance you can rework the primary and secondary navigation to use the menu system (rather than the theme system)?

If the primary/secondary links are moving into the menu system, one nice addition would be allowing the secondary link list to vary depending on what part of the site you're in. Currently it's useful only for "more universal links that get put somewhere else". It would be very nice to use it as truly secondary "sub menu" links. (Eg, you get one set of secondary links while under forum/*, another set under blogs/*, and another set while under foo/bar/*.)

I think the easiest way to do that would be to allow a given menu item to have an "only available on" dialog the way blocks do and the way the section module now does (see my recent patch to fix that up).

nice patch. the checkbox for deleting should only appear if you are editing a menu item, and not when adding one.

I don't understand why we need all those settings. If you give people the ability to administer menu's, you better trust them not to screw up. I'd add the 'weight'-option to the node submission form and get rid of all the rest.

I had a quick read through. Looks like a good idea.

You state "on all edit node pages". I think thats better said "On the node authoring form". This covers adding nodes as well. In the same description, I suggest putting 'primary links' in a theme('placeholder') so that text gets italicized. same for 'Parent'.

Should we still show all menus to administer menus folks? Just thinking out loud.

oops. Now I see that you need administer menus permission to see this section of the node form. Thats not what I was hoping for. I am happy to give permission to typical users of my intranet to their menu links but i wouldn't want to subject them to admin/menu. not a big deal though. i should have spoken up earlier.

Some of this functionality (and then some) is already in http://drupal.org/node/29621

- 'node' should be 'post'.

- 'Restrict Parent items to' should be 'Restrict parent items to'.

- '%menuitem' should probable be '%admin-menu-edit'. (We don't glue words together.)

- I dislike this part:

-  $options = menu_parent_options($edit['mid']);
-  $form['menu']['pid'] = array('#type' => select, '#title' => t('Parent item'), '#default_value' => $item['pid'], '#options' => $options);
-  $form['menu']['description'] = array('#type' => 'hidden', '#value' => $item['description']);
-  $form['menu']['path'] = array('#type' => 'hidden', '#value' => $item['path']);
-  $form['menu']['weight'] = array('#type' => 'hidden', '#value' => $item['weight'] ? $item['weight'] : 0);
+  // Generate a list of possible parents. Exclude this item and its children.
+  $pid = variable_get('menu_parent_items', 0);
+  $options = array();
+  $menu = menu_get_menu();
+  $depth = 0;
+  // if $pid is not root, add it to the option list
+  if ($pid > 0 && isset($menu['items'][$pid])) {
+    $depth = 1;
+    $title = $menu['items'][$pid]['title'];
+    if (!($menu['items'][$pid]['type'] & MENU_VISIBLE_IN_TREE)) {
+      $title .= ' ('. t('disabled') .')';
+    }
+    $options[$pid] = $title;
+  }
+  $options += menu_parent_options($item['mid'], $pid, $depth);

The old code seems to be a lot more elegant, and doens't expose menu system details in the form building code. Hairy. The rest of the code looks great.

Why are using an item instead of markup? Item is something that has a title.

I don't quite see how this addresses the problem of circular path aliases.
Also, please do not used escaped sinlge quotes inside translatable strings. If you need single quotes, use double quotes for the whole string.

Patch no longer applies.

Committed to HEAD. Thanks Richard.

Hmm,

I don't get it, is there any reason, why the menu settings are being shown on each post authoring form even if the user doesn't have any access to administer modules? Same applies to the path module. I did put in an extra if clause in each of these to prevent these settings to distort the form for users that don't need them / can't use them.

I can submit a patch if needed.

Waldemar

I meant to administer menus not modules of course :) Sorry.

One should read all issues before one is complaining. Sorry about that!