Closed (fixed)
Project:
Table of Contents
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
27 Oct 2008 at 17:23 UTC
Updated:
19 Jul 2009 at 09:20 UTC
This patch makes the
token editable in a settings page. This is to allow interoperability with the PEAR wiki filter that completely refuses to not filter out the current token.
| Comment | File | Size | Author |
|---|---|---|---|
| tableofcontents.patch | 4.78 KB | starbow |
Comments
Comment #1
deviantintegral commentedThanks for the patch. It looks to be pretty reasonable. Can you re-roll against the latest -dev branch? I've made some pretty significant changes, mainly implementing settings within each input format. If you could rework this so it fits within that form, and works with more than one input format, I'd be glad to test and commit this.
See #296171: Change Defaults?.
--Andrew
Comment #2
AlexisWilke commentedhi starbow,
What is that PEAR wiki does not like about the tag? How do you change it?
I think your patch is dangerous because any user could enter whatever and generate potentially dangerous problems on their system. So what I wanted to do on my end is offer only three possibilities:
[toc ...]
[tableofcontents ...]
<!-- tableofcontents ... -->
The 1st one would certainly be the default. And by offering a module that can remove those tags, I take care of the worry from the first author: a way to remove the TOC module and still not see the [toc ...] tags (although, a process to discover all the tocs would be more promising, I think... but that's a different story!)
Thank you.
Alexis
Comment #3
AlexisWilke commentedPEAR wiki support was added to version 3.x-dev Jul 5, 2009.
I will not add something in the settings so people can define the tag they want because that's too dangerous. Most people would not be able to enter a regex anyway!
Instead, I'll be happy to add regex'es as needed to the prepare function.
Thank you.
Alexis Wilke