Closed (duplicate)
Project:
Panels
Version:
6.x-2.0-alpha2
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Oct 2008 at 20:55 UTC
Updated:
29 Oct 2008 at 21:55 UTC
Users who do have access to Panels can still access the "Panel layout settings" and "Panel content" tabs when adding/editing/deleting content.
| Comment | File | Size | Author |
|---|---|---|---|
| PanelsBug.2.png | 13.93 KB | l10jennifer | |
| PanelsBug.1.png | 10.68 KB | l10jennifer |
Comments
Comment #1
brahms commentedI have the same problem. Though my user does not have any panels related permission, the two tabs "Panel layout settings" and "Panel content" are shown and can be accessed by this user when viewing or editing content.
I think the reason for this unwanted behaviour lies in the definition of the menu items in panels_node.module:
Here the access callback is node_access with access argument update. Therefore any user which has permission for updating content gets those panel tabs displayed when vieweing or editing a node.
I also noticed 2 errors in the menu item definitions above:
$items['node/%node/panel_layout']. I think the 3rd menu item should be something like$items['node/%node/panel_content']I made following modifications to those items to fix the 2 errors and to display the 2 tabs "Panel layout settings" and "Panel content" only for users which have access permissions 'create panel-nodes' granted (Though I don't know which permission is really intended for these 3 menu items):
Comment #2
sdboyer commented@brahms: Yes, that's where the problem is. Hence the giant FIXME notice. Adding access restrictions solves this problem indirectly, but doesn't really deal with the underlying issue. And that underlying issue has already been laid out in (at least five) other issues, so I'm marking this duplicate.
Comment #3
merlinofchaos commentedAlso I've fixed this in -dev already =)