Closed (fixed)
Project:
External Link Page
Version:
5.x-0.8
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
28 Oct 2008 at 07:29 UTC
Updated:
21 Jan 2009 at 07:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
zzolo commentedSure. It should be pretty simple. It may take a few weeks before I have the time to do it, though.
Comment #2
batbug2 commentedWell, i guess i'd have to convert it myself since i need it asap...
Comment #3
batbug2 commentedok, it was not too hard so i have somewhat converted it for myself. i have cut out the admin page because i don't really need it. therefore all values are hardcoded in the module. i can share my version if anyone is interested, just don't wont to publish it here because it is not complete port.
Comment #4
zzolo commented@batbug2
It would be helpful for myself and anyone that needs a D6 port of it, even if it is not a complete port. You can just attach attach it here.
Comment #5
batbug2 commentedOk, here it is. Complete module for 6.x.
Few notes:
As I said earlier, there is no admin page now, because I'm not really sure what is different in hook_form in 6.x so I have omitted it and all values are hardcoded. You can check them at the end of .module file.
All I had to change was hook_menu, and url() function. Aside from that, I think, there was nothing more to do.
There is still one bug remained from 5.x version that I should mention, because I don't know how to fix it myself: this module incorrectly converts the following type of links
http://bizmama.ru/index.php?option=com_content&view=article&id=46:2008-0...
Thought it correctly converts it in hook_filter, printing out the link like this:
http://yousite.ru/out?url=http://bizmama.ru/index.php?option=com_content...
The actual link it is trying to redirect to is http://bizmama.ru/index.php?option=com_content
Obviously this is because of the & character, but as I said, I don't really know how to fix it because I'm not really good at regular expressions.
Comment #6
zzolo commented@batbug2
Awesome! Thank you! Time is still limited but I will try to get to this soon. Yeah, regular expressions have always been a low point of mine as well. Thanks again.
--
zzolo
Comment #7
zzolo commentedDone and done. Thanks batbug2. I ported everything. So the admin settings are working. I also cleaned up the code and made things a little more simpler.