URL encoding problem - base64 not escaped correctly
koobla - October 28, 2008 - 20:05
| Project: | GTSpam |
| Version: | 5.x-0.4 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
I found a problem with some mail adresses and URL encoding:
take, for example the mail address vermessung@kolbe.at
After encoding, you get a base64-encoded argument to meilto.php that contains a '+'-sign.
This in turn results in the mail destination '0' in the mail browser.
At least for firefox the base64-string needs an additional escaping using urlencode before creating the link.
I simply inserted
$email = urlencode($email);
after line 161 i gtspam.module which resolved the issue.
#1
Good work.
Not a module I use (no 6.x version), but since I looked at this issue page, I thought I'd suggest that you should make a patch file for this.
The unix command is: "patch -u filename.orig filename". Should work from the command line on Mac as well.