regarding issue #258785: Provide more flexible settings for initial language on content types: is possible to integrate that patch into this module?
Regards

CommentFileSizeAuthor
#3 preserve_language-language_neutral.patch6.18 KBthepanz

Comments

Alice Heaton’s picture

Alice Heaton commented

Sure, I don't see why not.

It would require the module to run after the locale module so that the effects of the locale module can be reversed. I'll see if I have time to do this this week ; can't guarantee I will though !

thepanz’s picture

thepanz commented

Ok, thank you! If I'll have time in this two days I'll post you a patch for the module and the install file to update module weight :)
Wait 2 days before start coding! :)
Regards

thepanz’s picture

thepanz commented
Status: Active » Needs review
StatusFileSize
new preserve_language-language_neutral.patch6.18 KB

Hi, I've patched your module and changed requirements to only depend on "locate" module (I added some checks to be sure that i18n options will be available of i18n module is installed).

Regards

Alice Heaton’s picture

Alice Heaton commented
Status: Needs review » Reviewed & tested by the community

Hey great stuff ! I'm happy with the patch - code looks good, plus I tested it on my site and it didn't break anything :)

Did you write the .install file already ?

thepanz’s picture

thepanz commented

Seems that the .install file is correct (you already inserted the weight update there) and doesn't need any patch. But I'm not using i18n module and I can't test if there is any issue with weights :(

Regards

Alice Heaton’s picture

Alice Heaton commented
Status: Reviewed & tested by the community » Fixed

Ooops you're right ! I'd forgotten it did it - I've modified it so that it makes sure it's heavier than both i18n and locale.

I've now commited it to CVS - it will take up to 12 hours for the release to be available.

Thanx :)

thepanz’s picture

thepanz commented

Thanks, I'm using CVS to retrieve your module, so I don't need to wait! :)
Maybe would be nice to have a drupal--6 release (always in -dev, but tagged for D6)
I also added .pot and an Italian translation..

Regards

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.