The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.In considering the following patches:
#86462: add backend support for cck date fields
#321531: Provide signup form as a panel
and thinking about the D6 port (both because of how easy it is to split up the .module file into .inc files for various menu handlers, and because of how many files can be generated for D6 views2 support), I believe we need to restructure the directory layout of this module before I commit anything else to it.
Here's my proposal for how things should look right now:
CHANGELOG.txt
INSTALL.txt
README.txt
UPGRADE.txt
contrib/
contrib/signup_ecommerce
contrib/signup_conflicts
includes/
includes/event.5x-1.inc
includes/event.5x-2.inc
includes/event.none.inc
includes/views.none.inc
js/
js/node_form.js
js/admin_settings.js
po/
signup.css
signup.info
signup.install
signup.module
signup.rename.patch
signup.theme
views/
views/views.inc
After the other patches land, and a few other minor things, it'd look like this:
CHANGELOG.txt
INSTALL.txt
README.txt
UPGRADE.txt
contrib/
contrib/signup_ecommerce
contrib/signup_conflicts
includes/
includes/date.inc
includes/date.5x-1.inc
includes/date.5x-2.inc
includes/event.5x-1.inc
includes/event.5x-2.inc
includes/event.none.inc
includes/views.none.inc
js/
js/node_form.js
js/admin.settings.js
js/admin.content_types.js
panels/
panels/README.txt
panels/content_types/signup_form.inc
po/
signup.css
signup.info
signup.install
signup.module
signup.rename.patch
signup.theme
views/
views/README.txt
views/views.inc
views/views_default.inc
I'm not sure about even keeping the "contrib" directory at all. All that signup_ecommerce says is that it now lives in another project. signup_conflict hasn't worked since 4.7.x -- see #326110: where is contrib/signup_conflicts/signup_conflicts.module, so all that would be is either some dead code that needs updating, or a README pointing to the DRUPAL-4-7 branch or something. I think unloved add-ons to signup.module that I'm not planning to maintain along with the "core" signup module should just move into other projects entirely (what happened with signup_ecommerce) instead of having a subdir of signup.
During the conversion to D6 views2, the views directory might look more like this:
views/
views/views.inc
views/views_default.inc
views/handlers/
views/handlers/signup_views_handler_*.inc
views/plugins/
views/plugins/signup_views_plugin_*.inc
Anyway, thoughts on the new layout before I make it so?
Thanks,
-Derek
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 327726_signup_reorg.patch | 6.01 KB | dww |
| #2 | 327726_signup_reorg.cvs_rename.txt | 853 bytes | dww |
Comments
Comment #1
dwwBased on feedback from merlinofchaos in IRC, given the D6 theme template system, we might as well make a theme subdirectory now and move signup.theme in there, so we have a good place for all the separate theme template files during the D6 port. Also, I accidentally left in signup.rename.patch in the directory listing, please ignore. ;)
So, here's a new proposal:
Comment #2
dwwAttached are two things: a cvs_rename script for me to run on cvs.d.o to move the files around without losing revision history on them, and a patch to apply once it's done, to fix up the few calls to require_once() or drupal_add_js() that are effected by the initial change. Then, I'll just fix #86462: add backend support for cck date fields and #321531: Provide signup form as a panel to use the new layout before I commit them.
Comment #3
dwwRan the script and committed the patch to HEAD.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.