Three Problems in comment_page_display() on Drupal 6.
| Project: | Comment Page |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
I have discovered three problems in comment_page_display() for Comment Page 6.x-1.1, all three of which are patched in the attached diff.
First, as noted in #299933: Comment Page 6.x-1.1 not working?, $comment_id is not the CID, it is an object containing the CID. Which means the argument to _comment_load() is incorrect.
Second, _comment_load() does not load all the information required by theme('comment_view') into the comment object. Notably, user signature and user picture are both missing from the comment object. (Comment Module does an inner join with the {users} table to include these among other bits of info.)
Finally, $links is now the fourth argument to a 'comment_view' theme() call, not the third.
My patch probably isn't ready to be committed, but it's a start.
Comment Page solves a couple of major problems I've been having on my site, so I really hope you guys can solve these problems and keep this module maintained.
Let me know if I can help with testing, etc.
--Alex
| Attachment | Size |
|---|---|
| comment_page_fix.patch | 1.12 KB |
