Download & Extend

Update missing return value

Project:ImageCache
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

imagecache_update_5 (introduced in 5.x-2.2) doesn't return anything, consequently it causes an array merge error on update.

AttachmentSizeStatusTest resultOperations
patch.patch881 bytesIgnored: Check issue status.NoneNone

Comments

#1

+1 for this and the patch looks fine.

#2

can you just do a return array(); instead?

#3

Sure...

AttachmentSizeStatusTest resultOperations
patch.patch722 bytesIgnored: Check issue status.NoneNone

#4

Status:needs review» fixed

committed to DRUPAL-5--2... started to commit this to HEAD then realized that dopry never added the function to HEAD. so i copied the patch update in and committed to HEAD.

#5

Version:5.x-2.x-dev» 6.x-2.x-dev
Status:fixed» active

This is still not quite fixed: imagecache_update_5 (HEAD) does not have a return value.

#6

Status:active» fixed

right you are... i'd though i'd copied/pasted the patched version. committed to HEAD.

#7

I ran into this error updating to imagecache 2.2. Did it cause any problems? Do I need to reinstall anything? If yes, how can I do that from here? I bundled this upgrade with an awful lot of other ones and I don't want to revert to my old database & redo them all. BTW, everything looks like it is working fine.

#8

No, it doesn't cause any problems, but it's just an unpleasant error that may freak people out.

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.