after setting up some ads the ad block I set up is not showing up.
after tracking this down I discovered that before returning the block contents the contents ate then given to theme('ad_display') to theme the content. This is a problem since the hook_theme() function is commented out.
also the redirect page 'ad/redirect' doesn't work since the hook_menu() isn't completely compliant with the 6.x API.
There is more that can be fixed with 6.x, but with this patch the problems described are taken care of
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | ad_no_hook_theme_and_no_redirect.patch | 7.89 KB | jrglasgow |
| ad_no_hook_theme_and_no_redirect.patch | 5.9 KB | jrglasgow |
Comments
Comment #1
caprenter commentedJust to say, the patch worked for me.
Haven't tested it extensively, but after applying the patch at first I saw no difference. I ran the database update from admin - site building - modules, and suddenly the ads appeared.
Thanks for this.
Comment #2
jrglasgow commentedthere are no database updates, but running update.php refreshes the theme registry, same as Administer >> Site Configuration >> Performance and clicking "Clear Cache"
Comment #3
jrglasgow commentedI also found that at admin/content/ad/settings/configure there were tabs being displayed for modules that had no settings page, you were just getting a blank page with a "save" button, I removed the empty pages.
Also in the click_filter.module it is using the deprecated db_num_rows() which is no longer available in Drupal 6 so I fixed this as well. Attached is the improved patch.
Comment #4
jeremy commentedDo not combine multiple patches to multiple modules, that just makes things more difficult to review.
Your click_filter patch is a duplicate, please work from existing issues when possible.
Your patch to the base ad module should be attached to this issue to avoid redundancy. Leaving this open until you update your patch there, as I don't want to lose the patch, it is much appreciated.
Comment #5
jrglasgow commentedComment #6
mehmeta commentedOctober 31 snapshot reintroduces this issue, and going through the new ad.module and applying the changes in the patch by hand does not work. Any possibility that this patch can be updated for the latest snapshot and merged to the codebase?
Comment #7
mehmeta commentedOn top of the oct 31 snapshot I uncommented the DRUPAL_ROOT define in adserve.inc and set it to /home/ , and added the line $GLOBALS['devel_shutdown'] = FALSE; in serve.php, which made the ads appear again. What is the devel_shutdown global is for?