Posted by jumpfightgo@gro... on October 30, 2008 at 1:51pm
2 followers
| Project: | Wysiwyg |
| Version: | 6.x-0.4 |
| Component: | Editor - TinyMCE |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The safari plugin is missing as an available included plugin for the TinyMCE editor. I've never written a patch before, but if you insert the following code at line 452 of /editors/tinymce.inc then the safari plugin becomes available to profiles:
'safari' => array(
'path' => $editor['library path'] .'/plugins/safari',
'buttons' => array('print' => t('Safari')),
'url' => 'http://wiki.moxiecode.com/index.php/TinyMCE:Plugins/safari',
'internal' => TRUE,
'load' => TRUE,
),
Comments
#1
Hm. This means I interpreted #125267: Safari warning no longer supported completely wrong. ;)
Sorry, needs to be added back then.
#2
Hm. After looking at that patch again, it seems like the "safari_warning" editor configuration setting has been turned into a editor plugin.
So, what I'm asking myself now: Why don't we add this plugin by default? According to http://wiki.moxiecode.com/index.php/TinyMCE:Plugins/safari, it won't be loaded for other browsers anyway...
#3
Committed attached patch, which adds the Safari plugin as regular plugin. We might come back to the idea in #2 someday - since we have jQuery, we can determine the browser and automatically add the plugin via JavaScript, before the editor is attached. Oww, that sounds nice. ;)
#4
Automatically closed -- issue fixed for two weeks with no activity.