I am also attempting to use the ApacheSolr module and has enabled this module in order to turn off the Content and User searches. I applied the patch without any problems.
My problem comes in because I have the advanced_help module installed as well. The search_get_implementing_modules() is basically the same implementation as module_implements except that it forces 'by name' sorting instead of the default 'by weight/by name' sorting.
This appears to have been an attempt to get the apachesolr search implementation to be the first in the list, but as you can see, this was not effective in ALL cases. I would recommend/prefer that we go back the module_implements and use the ability to set a module weight at install time to get the apachesolr_search module as the first search.
I can attempt to fix the patch and resubmit if this is the desired action.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | DRUPAL-6-4.patch | 19.73 KB | chuckdeal97 |
Comments
Comment #1
chuckdeal97 commentedI took the DRUPAL-6-3.patch and corrected the search.module and search.pages.inc stuff that I mention in the issue. Now when I set the apachesolr_search to a weight of -10 it is the "default" search, just as I wanted.
Comment #2
brainski commentedThanks for the patch
This one works also for drupal 6.9. The original patch is not applicable. Maybe the owner of the module should update it.
Comment #3
robertdouglass commentedbrainski - so you could mark it reviewed and tested by community? :D
Comment #4
robertdouglass commentedThanks.
Comment #5
robertdouglass commentedI should add that I left the earlier patch in there, and added this patch, as is, and thus the two are slightly different in an undocumented way (except for this issue, of course).
Comment #6
brainski commentedTested this patch ind it worked fine for me.
Comment #7
robertdouglass commentedhaha! Thanks brainski - extra reviews always welcome. I had committed it yesterday already =)