Country code loads an include file in hook_boot. If aggressive caching is enabled, this file is not loaded and the site breaks with a missing function fatal error.

It's okay for the module not to work with aggressive caching - there's a warning on the form for caching settings - but the site shouldn't break.

Really, we don't need to have most of this code in an include file. If it's always required, it could be straight in country_code.module. The reason we're using an include file appears to be to prevent a function conflict if any other module includes one of the path rewrite functions. We could still do this if we limited the include file to these two path rewrite functions, moving the rest to country_code.module.

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Should we test for aggressive caching in hook_requirements() and issue a warning?

stella’s picture

stella commented

The patch in http://drupal.org/node/323474 fixes this issue. The patch doesn't apply cleanly, but if you apply it manually it solves the issue.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Hmm. Probably we shd still fix it in country_code, since even if that patch is accepted it may be some time before it reaches a D6 stable release.

stella’s picture

stella commented
Status: Active » Fixed

Workaround in country_code module committed to CVS - country_code.inc is now merged into country_code.module where possible.

Cheers,
Stella

catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Postponed

Marking postponed against #323474: hook_boot() not invoked on uncached page views if cache mode is AGGRESSIVE so we can go back to this later once it gets in if necessary.