Port to Drupal 6
Artem - October 30, 2008 - 20:34
| Project: | Google Ad Manager |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
It would be great if this module could be ported to Drupal 6. Using module is easier, than manual insertion of Google codes into a theme template.
I know that you are not going to port this module right now. Well, hopefully with the help of this issue I (and others interested) would be able to watch for updates and maybe join the development ;)
#1
Feel free to submit a patch for the upgrade to D6 or simply a fully working Drupal 6 version.
For very handy help how to create an upgrade: http://www.lullabot.com/videocast/porting-drupal-modules
For the moment, I don't have time free but I'm accepting patches.
#2
I spent some time hacking and made it work on Drupal 6. Find the ported version attached. I converted basic stuff with the help of the deadwood module and after that most of the change was to replace theme() call with the direct call theme_google_admanager_block()
Not a polished version, but works for me and I tried keeping it close to the original version so that it would be easier to maintain.
Have fun!
#3
Hi Artem,
Good work, but I'm afraid the job is not done yet. You checked out the 1.1 version and not the dev release. The development release comes with a filter which implements 3 extra functions: google_admanager_filter, google_admanager_filter_tips and _google_admanager_substitute_tags.
So, if your Drupal 6 port would be enhanced with the filter functions, I will check in D6 dev release.
#4
True, I didn't start with the dev version. Will try repeating. Couple of filter related functions shouldn't be a too big deal.
#5
And here is the dev version. With the filters
#6
Thanks a lot Atem. I didn't test the module but I checked it in. Within 24 hours, it should appear in the list of releases as 6.x-1.x-dev.
So, the code still needs review by others before a stable 6 release can be made.
Thanks for the work again!
#7
Drupal 6 dev release it out. We need some positive comments of users successfully using the dev release before making an official stable release.
#8
I've got it running on a live site now. Haven't messed with too many features yet but the ads are there.
I did find one error in the dev version. White space in the ad slots list on the configuration page isn't actually stripped out. Here's a patch (my first ever, so I apologize if I didn't do it right).
#9
Patch applied and committed. Thx!
#10
Based on the test report by jumpfightgo, I released a stable Drupal 6 package which will come available shortly.
In case of bugs, open a new issue.
#11
Automatically closed -- issue fixed for two weeks with no activity.