It would be great if this module could be ported to Drupal 6. Using module is easier, than manual insertion of Google codes into a theme template.

I know that you are not going to port this module right now. Well, hopefully with the help of this issue I (and others interested) would be able to watch for updates and maybe join the development ;)

CommentFileSizeAuthor
#8 google_admanager_trim.patch597 bytesjumpfightgo@groups.drupal.org
#5 google_admanager6-dev.zip9.25 KBArtem
#2 google_admanager6.zip8.72 KBArtem

Comments

toemaz’s picture

toemaz commented

Feel free to submit a patch for the upgrade to D6 or simply a fully working Drupal 6 version.
For very handy help how to create an upgrade: http://www.lullabot.com/videocast/porting-drupal-modules

For the moment, I don't have time free but I'm accepting patches.

Artem’s picture

Artem commented
StatusFileSize
new google_admanager6.zip8.72 KB

I spent some time hacking and made it work on Drupal 6. Find the ported version attached. I converted basic stuff with the help of the deadwood module and after that most of the change was to replace theme() call with the direct call theme_google_admanager_block()

Not a polished version, but works for me and I tried keeping it close to the original version so that it would be easier to maintain.

Have fun!

toemaz’s picture

toemaz commented
Status: Active » Needs work

Hi Artem,

Good work, but I'm afraid the job is not done yet. You checked out the 1.1 version and not the dev release. The development release comes with a filter which implements 3 extra functions: google_admanager_filter, google_admanager_filter_tips and _google_admanager_substitute_tags.

So, if your Drupal 6 port would be enhanced with the filter functions, I will check in D6 dev release.

Artem’s picture

Artem commented

True, I didn't start with the dev version. Will try repeating. Couple of filter related functions shouldn't be a too big deal.

Artem’s picture

Artem commented
Status: Needs work » Needs review
StatusFileSize
new google_admanager6-dev.zip9.25 KB

And here is the dev version. With the filters

toemaz’s picture

toemaz commented

Thanks a lot Atem. I didn't test the module but I checked it in. Within 24 hours, it should appear in the list of releases as 6.x-1.x-dev.
So, the code still needs review by others before a stable 6 release can be made.

Thanks for the work again!

toemaz’s picture

toemaz commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Active

Drupal 6 dev release it out. We need some positive comments of users successfully using the dev release before making an official stable release.

jumpfightgo@groups.drupal.org’s picture

jumpfightgo@groups.drupal.org commented
StatusFileSize
new google_admanager_trim.patch597 bytes

I've got it running on a live site now. Haven't messed with too many features yet but the ads are there.

I did find one error in the dev version. White space in the ad slots list on the configuration page isn't actually stripped out. Here's a patch (my first ever, so I apologize if I didn't do it right).

toemaz’s picture

toemaz commented

Patch applied and committed. Thx!

toemaz’s picture

toemaz commented
Version: 6.x-1.x-dev » 6.x-1.0
Status: Active » Fixed

Based on the test report by jumpfightgo, I released a stable Drupal 6 package which will come available shortly.
In case of bugs, open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.