This may not be as much of an issue if we get more test slaves, but it might be a good idea to ignore test results for issues that have been since marked as fixed.

Otherwise it will mark them as patch does not apply due to the patch having already been committed.

Example: #305150: Keep running tests checked

CommentFileSizeAuthor
#2 pift_check_test.patch3.02 KBhunmonk

Comments

boombatower’s picture

boombatower commented

From seeing this on more issues I would much prefer if the results were ignored after issue is no longer eligible.

Same logic used in #325481: Mark issues as CNW when most recent patch has failed testing can be applied for checking.

hunmonk’s picture

hunmonk commented
Title: Consider not overrideing test results when issue has been closed » don't update test results if the issue doesn't pass PIFT's issue filters
Status: Active » Postponed (maintainer needs more info)
StatusFileSize
new pift_check_test.patch3.02 KB

attached has been fairly thoroughly tested, committed to 5.x and HEAD, and deployed on project.drupal.org. leaving as needs more info -- please somebody, run some tests on project.drupal.org and make sure it works as expected.

catch’s picture

catch
he/him
Primary language English
commented

Will test this later today.

alexanderpas’s picture

alexanderpas commented
Priority: Normal » Critical

Critical as per:
http://drupal.org/node/329973

There are a few outstanding issues that need to be addressed before the maintenance

catch’s picture

catch
he/him
Primary language English
commented

I tested this on project.drupal.org, and it ignores passes and fails when the current status is invalid. Looks good to me.

hunmonk’s picture

hunmonk commented
Status: Postponed (maintainer needs more info) » Fixed

great, i guess we're done here since the code was already committed.

thx catch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.