Drupal 6?

Flying Drupalist - October 31, 2008 - 03:28
Project:Panels Accordion
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:lefnire
Status:closed
Description

Hi, will this module be updated to drupal 6?

#1

davexoxide - November 29, 2008 - 22:19
Assigned to:Anonymous» davexoxide

This module barely got any attention while it was in D5... but fortunately some free time has presented itself and I'm going to be paying more attention.

It's a relatively small module so I will try to get a D6 alpha released soon. Sorry for the delay.

#2

Flying Drupalist - November 29, 2008 - 22:50

No problem! Thanks a lot :)

#3

ahkiam - January 3, 2009 - 04:15

+1 for 6.x port

#4

manoz_79 - January 23, 2009 - 13:45

+1 subscribing

#5

darumaki - February 4, 2009 - 22:07

+1+1

#6

pribeh - May 29, 2009 - 17:12

uber-double-plus-good = +3.14

#7

pribeh - June 16, 2009 - 16:37

I'll put up a bounty for this if someone wants to take this on. davexoxide?

#8

matthew petty - September 7, 2009 - 04:02

Subscribing... I could replicate Politico.com's snazzy teaser's like this.

#9

lefnire - October 2, 2009 - 22:08

Here it is!

(Note: it now depends on jquery_ui -- trust me, this is a good thing. panels_tabs depends on tabs which *will* depend on jquery_ui, which will provide an updated/defacto version of accordions, tabs, etc -- and it's in D7 core, removing that dependency in the future)

AttachmentSize
panels_accordion.tgz 8.83 KB

#10

lefnire - October 2, 2009 - 22:19
Status:active» needs review

#11

pribeh - October 3, 2009 - 02:28

Hi, thanks so much for doing this lefnire! I just got it working. Everything seems to work great here.

One challenge is that I have no idea what selector to put in the "active" box so that the first pane appears expanded by default. Any help is appreciated.

#12

davexoxide - October 3, 2009 - 22:27

@lefnire that's awesome! Thanks for stepping up and doing this.
I'll be submitting it and creating a dev release this evening with all credit going to you.

EDIT: Smart move to use jQuery UI as well.

#13

lefnire - October 3, 2009 - 23:59

yeah, this thing is a key component for my work at GoingOn networks. If the bugger's stressing you out, we could take it off your hands as maintainer

#14

lefnire - October 4, 2009 - 00:01

pribeh: in the "active" box, you just put a number (0 for the first pane as "expanded", 1 for the second, etc). I wanted to rename this to "expanded" to make it more clear; however, just copy/pasting the options as is (name & values) from the jquery_ui accordion proved a really slick way to manage settings. Open for debate :)

#15

pribeh - October 4, 2009 - 00:23

This really is superb - thanks Lefnire. I don't see any issue with the name just needed a simpler explanation (such as 0 for first pane, etc.) than what I saw on the jquery page.

#16

pribeh - October 8, 2009 - 02:33

Hi lefnire. One final issue (I hope): the height of .ui-accordion .panel-pane seems to be fixed at the height of the tallest pane. I can't override it via CSS to auto or anything else. Is there a way to accomplish an auto or flexible height to the block? I attached an image to help illustrate.

AttachmentSize
Picture8.png 55.08 KB

#17

pribeh - October 16, 2009 - 23:31

lefnire, I can't find the javascript responsible for this. Any help would be much appreciated.

#18

lefnire - October 20, 2009 - 17:24

pribeh, I committed a 6.x-dev version which enables the "autoheight property" (you can set to true or false in the pane-style settings dialog). See if setting that to false doesn't fix it for you

#19

pribeh - October 20, 2009 - 17:50

Wicked stuff. Thanks a lot lefnire!

#20

lefnire - October 20, 2009 - 17:53

I'm actually just dumping the options available from UI Accordion as-is into panels_accordion_style_settings_form(). I stopped at a certain point because I thought I was cluttering the pane-style settings dialog, potentially confusing the user. So if there are any other options you think should go in, give me a shout-out.

PS, did it work did it work? Also, any thoughts why the dev release isn't showing up on the project page? I hate cvs :(

#21

pribeh - October 20, 2009 - 20:02

Ya, I'm still waiting for the dev to show up... CVS takes sooo long.

#22

lefnire - October 21, 2009 - 19:03
Version:5.x-1.x-dev» 6.x-1.x-dev
Assigned to:davexoxide» lefnire

finally, check now

#23

davexoxide - October 22, 2009 - 00:56

lefnire, I'm a complete rookie when it comes to CVS. How did you remove files after branching?

#24

lefnire - October 26, 2009 - 16:59

Dude, right there with you on the rookie thing. IIRC I ran cvs delete js/jquery.cookie.js && cvs delete js/It didn't delete js/ on my local, and I was surprised it worked in the repo because I'd read you can't delete folders in cvs :s

#25

pribeh - October 26, 2009 - 17:46

Thanks for the work on this lefnire. Everything seems to work great. I'll make future feature requests or bug reports in new issue threads.

#26

lefnire - October 26, 2009 - 23:49
Status:needs review» closed
 
 

Drupal is a registered trademark of Dries Buytaert.