Closed (fixed)
Project:
Frequently Asked Questions
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Oct 2008 at 10:25 UTC
Updated:
5 Jan 2009 at 22:35 UTC
1) hook_load should return only additions to node
2) in faq_load no check about result
if nothing is loaded there's notice and lost title of node
here the patch
| Comment | File | Size | Author |
|---|---|---|---|
| faq_load.patch | 751 bytes | andypost |
Comments
Comment #1
stella commentedWhy are you removing the line:
Comment #2
andypostBecause
1) if $result is FALSE $node->title sets to empty value - title become empty on save
2) hook_load returns only additions that merge into node - no need to modify $node object
3) return of $result with only 2 fields (question and new title) is more quick on merge which happens after
please, take a closer look to http://api.drupal.org/api/function/hook_load
Comment #3
stella commentedCommitted, thanks! Will be included in the next release. Back-ported to Drupal 5 as well.
Cheers,
Stella
Comment #5
stella commentedReleased in 5.x-2.12 and 6.x-1.8.