Hello, after upgrading to the 5.x-1.0-alpha13, I have noticed, that links to the last posts in the forums list (last column "Last post") are got broken. Seems like in all last post links the part after # is missing. I mean that e.g. it should be something like: www.example.com/forum/nid?page=2#comment-cid , but now it is just www.example.com/forum/nid?page=2#

please, share your ideas, I don't know where is the problem, may it be that where were some code lines missing in the alpha13?

Comments

michelle’s picture

Status: Active » Fixed

It's not broken, really, just a tiny nit I guess. It shouldn't have the # there when there's no new posts. When there is new posts, it correctly links to #new. I changed it so it leaves the # off when there's no new posts on the thread.

Michelle

transliteration’s picture

ah, i see, thank you, I just misunderstood the functionality.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

transliteration’s picture

Status: Closed (fixed) » Active

Although, I just have one question. As I have seen in the other forums, they normally have in that column of the topics list, the link to the last post in the topic. Do you plan to do the same later or you prefer this link to refer only to the new post (if there is one) or to the first post of the last page (the behavior when there is no new post)?

michelle’s picture

Status: Active » Fixed

It's not a matter of preference but of performance. Getting the ID of the latest comment caused a serious performance hit that plagued the module all last summer, which is why it was rewritten to simply go to the newest.

Michelle

transliteration’s picture

ok, it is clear now, why it is so. Thanks for the quick answer, and all the best for you, I appreciate the module a lot!

michelle’s picture

No problem. Glad you like it.

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.