base_path patch No Joy yet

I haven't applied the patch yet ;) But a visual inspection of the patch looks promising. I will try to set up a test site with this tonight, when the kid has fallen asleep.

I've patched ImageBrowser with #3 and it doesn't solve all the problems. I still get "loading", but now the windows seems to find more of its elements than before, the loading has moved to the middle of the window, instead of as a list item just under the "All|mine" drop down.

I checked out your javascript and it makes the same assumption. Of course, now I should have attahced a patch file, but unfortunately I don't know how to get the basepath. Well, I think I do...you could put the basepath as a) a hidden field b) as a base path variable in the head of the form you output and then use js to get that basepath.

There might be a Drupal js function to call as well, but I didn't find any in drupal.js.

Line 311:

        $row[] = '<a href="javascript:SelectFile(\'/imagebrowser/view/image/'.$nid.'/'.strtolower($size['label']).'\', \'\', \'\', \''.$node->title.'\');">Insert</a>';

to:

        $row[] = '<a href="javascript:SelectFile(\''.base_path().'/view/image/'.$nid.'/'.strtolower($size['label']).'\', \'\', \'\', \''.$node->title.'\');">Insert</a>';

Line 332:

          $row[] = '<a href="javascript:SelectFile(\'/imagebrowser/view/imagecache/'. $nid.'/'.$preset['presetname'].'\',\'\',\'\',\'\');">Insert</a>';

to

          $row[] = '<a href="javascript:SelectFile(\''.base_path().'/view/imagecache/'. $nid.'/'.$preset['presetname'].'\',\'\',\'\',\'\');">Insert</a>';

Those two previous blocks of code are very similar, I would have refactored them out into a function, and just sent the path elements which are different into it, especially if there might be more if/else clauses in the future (for asset module, for filefield module etc).

Finally you need to change:

Line 232:

    $output .= '<li><a href="/imagebrowser/load/imagedetails/'.$image->nid.'"><img src="/imagebrowser/view/image/'.$image->nid.'/thumbnail" alt="'.$image->title.'"/></a></li>';  }

Needs to be changed to:

  $preset_size = "thumbnail"; // Change to a load var preset in the future?
  
  $file = new stdClass();
  $file->fid =  db_result(db_query("SELECT fid FROM {image} WHERE nid = '%s' AND image_size='%s'", $image->nid, $preset_size));
  $file->filepath = db_result(db_query("SELECT filepath FROM {files} WHERE fid = '%s' AND filename='%s'", $file->fid, $preset_size));
  
  $output .= '<li><a href="'.base_path().drupal_get_path('module', 'imagebrowser').'/load/imagedetails/'.$image->nid.'"><img src="'.base_path().$file->filepath.'" alt="'.$image->title.'"/></a></li>'; }

Line 266:

      $output2 = '<div class="image"><img src="/image/view/'.$nid.'/thumbnail" alt="Thumbnail" /></div>';

to:

      $preset_size = "thumbnail"; // Change to a load var preset in the future?
  
  	  $file = new stdClass();
  	  $file->fid =  db_result(db_query("SELECT fid FROM {image} WHERE nid = '%s' AND image_size='%s'", $image->nid, $preset_size));
 	  $file->filepath = db_result(db_query("SELECT filepath FROM {files} WHERE fid = '%s' AND filename='%s'", $file->fid, $preset_size));

      
      $output2 = '<div class="image"><img src="'.base_path().$file->filepath.'" alt="Thumbnail" /></div>';

The above works with table name prefix and installed in a subdirectory, there are still bugs, when clicking on an image the javascript won't update the "Insert Image" fieldgroup. I think that's because I'm using "Clean URLs" and "Auto Nodetitle", so there has to be a call to a proper function to fix that.

I'll don't know if I can make a patch, I will try, but I'm saving this so it won't get lost ;)

Another patch, I added drupal_get_path_alias it didn't break anything which wasn't broken already, but I don't know if it does the right thing either ;)

BTW, my patches are against a clean dev version, without any patches applied before. So the patch in #7 includes #6 and #3 in the same patch.

BTW, I wouldn't touch the javascript, it seems I might be mistaken there, I read the:

$("#browse .browse").load('/imagebrowser/load/images/'+filter+'/'+sort+'?page='+parts[1], function() {
      prepareLinks(this);

And thought it needed the subdir I installed in infront, but now I notice that it is just using the module path, and I can't see how you find the rest of the path, thus I'm not sure where the paths are comming from, probably some of the PHP.

I should test on a webserver where I don't have a subdirectory, but all my development is done on xampp on Mac, so it is a bit of a hassle to upload unfinished stuff to a server ;)

Best regards,
Paul

The file upload works from the ImageBrowser. Now, will you create a NodeBrowser ;)

Hmm, wonder how much work that would be if I started with the image browser?

I think we need to add the $lang variable to the drupal_get_path_alias, but that needs an optional drop down in the ImageBrowser to sort images based on language of the node they belong to. That is needed for most of the sites I use, and epsecially the one where I want to add this functionality to.

The images will in most cases have the same files though, so the file look up I've added should be okay.

Tnx, as soon as I see a new package I'll download and test here.

The 6.x-dev packaged worked pretty well.

I'll file separate issues for other problems, as they arise.