I've been testing the module a little bit, it works great. I was used to image assist, and I might switch to this.. we'll see.
But one thing that image-assist was doing and that is not properly done here is the image permissions... let me explain.
I sometime am in the situation that I want the users to see the images I upload, but I don't want them to have the access to the image node itself, even though I prefer my images to be nodes... So the solution in a simple drupal configuration is to unpromote to the front page by default the image content type. and then, users don't see it..
users.. no, but google does ! So the users might still be able to arrive on the website through these image nodes that I don't want them to see... next solution : unpublishe by default the image nodes... that works in image-attach, but with imagebrowser, user now not only don't have access to the image nodes, (and that's cool) but they also can't see the images embeded in the content (and that's not cool). Even worse, the admin himself cannot add images anymore, as they do not show up in the image list.
Users should be able to see images in content, even from unpublished nodes, as well as editors when they want to add images... but is there another solution that I didn't think about ?
I see that your issue list is expanding fast, take this as a sign that people (me included) really appreciate your module.
Comments
Comment #1
jdelaune commentedI would go as far as saying my module is probably more secure then. I spent a while thinking about all the possible combinations of permissions.
Say you had a suspect images and you needed to disable it for more investigation. You would want to unpublish the node and hope that all the references to that node no longer has access. Which is what currently happens.
Would love other people's thoughts on this matter.
Humour me in doing this though, if you are familiar with code:
lines 223 and 226 of imagebrowser.module contain SQL queries. Remove the following from both:
AND n.status = 1This should allow your editors to view the images for inserting. As for viewing the images in the page this is part of image.module. Line 634-636. Try removing those and seeing what happens.
Hope that helps.
Comment #2
jdelaune commentedComment #3
jdelaune commentedRe-open if this becomes an issue.