Active
Project:
lm_paypal
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2008 at 00:13 UTC
Updated:
18 May 2011 at 08:17 UTC
The current code sometimes constructs entire SQL queries dynamically (potentially opening some possibility for security holes, creating DB portability issues, inefficiency etc), when it should perhaps consider using the "array of query arguments" option in db_query.
For D6, consider using (Schema API) methods drupal_write_record and drupal_schema_fields_sql to reduce coupling between the defined schema, and the SQL being generated.
Comments
Comment #1
john franklin commentedKick this down the line to 6.x-2.x.