At the top of friendlist_ui_get_link(), there is the following code

  $account = friendlist_api_user_into_uid($account);

  // The user is "self": return nothing.
  if ($user->uid == $account->uid) {
    return '';
  }

This code never succeeds, because friendlist_api_user_into_uid() always returns a uid not an object, and thus $account->uid never exists. It should just be $account. I discovered this because this line threw a PHP notice (Trying to get property of non-object in friendlist_ui.module on line 281), so as you see having E_ALL turned on can find bugs too.

There are a great many more notices throughout the modules and they are undoubtedly causing bugs at time. I encourage you to find and fix them, I'm out of energy to do so tonight.

CommentFileSizeAuthor
object.patch347 bytesgdd

Comments

mercmobily’s picture

Status: Needs review » Fixed

Hi,

Applied -- good catch!

Merc.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.