After installation and activation of the module_builder on my site with drupal6.2 and PHP5.2.4, I got following warning:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of form_get_cache(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in mysite/httpdocs/sites/all/modules/module_builder/module_builder.api.inc on line 128

CommentFileSizeAuthor
#2 module_builder.passbyref.patch642 bytesJamesAn

Comments

jfillmore’s picture

jfillmore commented

There is an & in the call on line 128 that doesn't need to be there so

$form = form_get_cache($form_build_id, &$form_state);

Should be

$form = form_get_cache($form_build_id, $form_state);

JamesAn’s picture

JamesAn commented
Status: Active » Needs review
StatusFileSize
new module_builder.passbyref.patch642 bytes

Here's the one-line changed wrapped up as a patch. Can a maintainer confirm this patch?

joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks for the fix. Committed.

(Though you guys know that the D6 version of this doesn't actually do anything right now, yeah?)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.