Call-time pass-by-reference has been deprecated
bruijn - November 1, 2008 - 14:09
| Project: | Module Builder |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
After installation and activation of the module_builder on my site with drupal6.2 and PHP5.2.4, I got following warning:
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of form_get_cache(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in mysite/httpdocs/sites/all/modules/module_builder/module_builder.api.inc on line 128
#1
There is an & in the call on line 128 that doesn't need to be there so
$form = form_get_cache($form_build_id, &$form_state);Should be
$form = form_get_cache($form_build_id, $form_state);#2
Here's the one-line changed wrapped up as a patch. Can a maintainer confirm this patch?
#3
Thanks for the fix. Committed.
(Though you guys know that the D6 version of this doesn't actually do anything right now, yeah?)
#4
Automatically closed -- issue fixed for two weeks with no activity.