Closed (duplicate)
Project:
Project Issue File Review
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2008 at 17:35 UTC
Updated:
13 Nov 2008 at 22:49 UTC
This patch is reporting an "Invalid PHP syntax". However, the syntax appears to be correct.
Is the report caused by non-PHP code in the patch?
Comments
Comment #1
boombatower commentedI debated if PIFR should check if the files changed are PHP or not, but then I figured that PHP syntax checker should work with HTML and such as you can embed PHP in an HTML page. So it should work fine if the patch doesn't have PHP in a file that it changes.
If you link to the actual patch I can check it out, otherwise one thought might be that the patch doesn't apply correctly and causes a PHP syntax error.
Please point me to the patch you are having the issue with.
Comment #2
boombatower commentedI've reset all the issues to be retested in case an error cause that as I couldn't see problems myself.
I double checked and PHP syntax checker won't throw error if non-php file. My only guess is that the patches either didn't apply correctly or the file changed as non-php and had <? or <?php somewhere, but I ddin't see any of that...so not sure.
Comment #3
cooperaj commentedI'm getting this error for this patch: http://drupal.org/node/158445
It's a .htaccess patch. At my last check it applied just fine (though that may have changed recently)
Comment #4
boombatower commentedCheckout my issues at #332967: Detect non-unix newlines
Comment #5
boombatower commented