Hi,

I was testing the 6.x-dev version of this module with various editors.
After installing the editors in the right folders, i went to the Wysiwyg settings and assigned FCKeditor to the Filtered HTML format & TinyMCE to the Full HTML format.

Next, eager to test, i went to node/add/page, but saw a whole bunch of errors like the ones below:

    * notice: Undefined index: block_formats in /Users/svendecabooter/Projecten/wysiwyg6/sites/all/modules/wysiwyg/editors/fckeditor.inc on line 93.
    * notice: Undefined index: apply_source_formatting in /Users/svendecabooter/Projecten/wysiwyg6/sites/all/modules/wysiwyg/editors/fckeditor.inc on line 94.
    * notice: Undefined index: preformatted in /Users/svendecabooter/Projecten/wysiwyg6/sites/all/modules/wysiwyg/editors/fckeditor.inc on line 95.
    * notice: Undefined index: css_setting in /Users/svendecabooter/Projecten/wysiwyg6/sites/all/modules/wysiwyg/editors/fckeditor.inc on line 104.
    * notice: Undefined index: css_setting in /Users/svendecabooter/Projecten/wysiwyg6/sites/all/modules/wysiwyg/editors/fckeditor.inc on line 110.

It took me a minute to find out this was because i didn't click the 'edit' link in the administration settings to configure each editor. After i did that, the errors disappeared.

Perhaps a more descriptive error could be shown, or at least some instruction text in the admin settings.
I assume this is not high on your priority list, but it might scare some users if they come in the same situation as i did.

Kind regards,

Sven

CommentFileSizeAuthor
#3 wysiwyg-DRUPAL-5.notices.patch9.45 KBsun
#3 wysiwyg-HEAD.notices.patch9.4 KBsun
#1 wysiwyg-HEAD.fckeditor-notices.patch1.99 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Component: Code » Editor - FCKeditor
Status: Active » Needs review
StatusFileSize
new wysiwyg-HEAD.fckeditor-notices.patch1.99 KB

Thanks for reporting. Support for FCKeditor is very limited so far, since developers/maintainers of FCKeditor promised to take this over, but unfortunately did not do anything about it yet.

Attached patch should fix the PHP notices.

sdecabooter’s picture

sdecabooter commented

Hi,

I'll check the patch later on.
Forgot to mention that i got the same type errors when trying to load the TinyMCE editor on a page, when i didn't save the settings yet.

Sven

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Undefined index errors when editors not configured » PHP notices when editors are not configured
Component: Editor - FCKeditor » Code
Status: Needs review » Fixed
StatusFileSize
new wysiwyg-HEAD.notices.patch9.4 KB
new wysiwyg-DRUPAL-5.notices.patch9.45 KB

Oh crap.

Committed attached patch, which fixes all PHP notices when editors are just assigned, but not configured. We need to properly handle default values for editors in #313497: Allow configuration of advanced editor settings.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.