Hi,

I was testing an issue with e-Commerce and found that when I removed the module with the access plugin it would crash the entire system and I was not about to reload it, without this fix.

See patch

Comments

merlinofchaos’s picture

Status: Active » Needs work

This only checks at menu build time. What if something happens to remove the plugin later? It seems like views_access is a better place to check.

merlinofchaos’s picture

Or perhaps...a second place to check. Or maybe it already does.

dagmar’s picture

Version: 6.x-2.1 » 6.x-2.8
Status: Needs work » Needs review
Issue tags: +alpha-2 blocker
StatusFileSize
new771 bytes
new758 bytes

I think we only have to ensure that at least an access plugin is loaded.

Maybe a check in views_access would be usefull, but this is the same case that #570580: query->add_where() accepts empty clause string and results sql error if we check this in views_access we cannot know if module are doing the things in the wrong way.

dawehner’s picture

StatusFileSize
new778 bytes
new765 bytes

Wouldn't it be enough to check for isset? This is just a minor performance issue.

      $plugin = views_get_plugin($type, $name);
      if (!$plugin) {
        return;
      }

This does return NULL, so isset would be false if the access is not there.

merlinofchaos’s picture

Version: 6.x-2.8 » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Needs porting to 7.x. Committed to all 6.x branches.

dawehner’s picture

Issue tags: -alpha-2 blocker

remove tag.

dawehner’s picture

Status: Patch (to be ported) » Fixed

and fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.