Hi,
I was testing an issue with e-Commerce and found that when I removed the module with the access plugin it would crash the entire system and I was not about to reload it, without this fix.
See patch
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | views-329044.patch | 765 bytes | dawehner |
| #4 | views-329044-views3.patch | 778 bytes | dawehner |
| #3 | views-329044-views2.patch | 758 bytes | dagmar |
| #3 | views-329044-views3.patch | 771 bytes | dagmar |
| views_access_callback.patch | 911 bytes | gordon |
Comments
Comment #1
merlinofchaos commentedThis only checks at menu build time. What if something happens to remove the plugin later? It seems like views_access is a better place to check.
Comment #2
merlinofchaos commentedOr perhaps...a second place to check. Or maybe it already does.
Comment #3
dagmarI think we only have to ensure that at least an access plugin is loaded.
Maybe a check in views_access would be usefull, but this is the same case that #570580: query->add_where() accepts empty clause string and results sql error if we check this in views_access we cannot know if module are doing the things in the wrong way.
Comment #4
dawehnerWouldn't it be enough to check for isset? This is just a minor performance issue.
This does return NULL, so isset would be false if the access is not there.
Comment #5
merlinofchaos commentedNeeds porting to 7.x. Committed to all 6.x branches.
Comment #6
dawehnerremove tag.
Comment #7
dawehnerand fixed