Notices in ActionsConfigurationTestCase

Talked with chx and decided upon following.

Fixed else if -> elseif

and got rid of stuff for other patch.

From #drupal:
* else if should be elseif
* count() is slow; just elseif ($this->defaultFields) will do.

Removed count() from both for consistency.

and fixed tabbing in pgsql file.

Confirmed all database tests pass, code looks good, although it'd be nice for Crell to have a look at it when he's around. However, we need to get those tests passing again. :)

Committed to 7.x. Thanks!

How were we even getting this? Was this caused by the insertFields array being empty? Right now calling InsertQuery::execute() without fields is a bug in the calling code. Having it insert a default row instead is NOT the way to fix it. Having it not insert at all is the way to fix it, or else throwing an exception.

Unless I'm misunderstanding this issue entirely we just traded one bug for another.

Ok. Rolled back that patch. Let's try again. :)

is this a duplicate of #321056: PHP warnings using db_insert('actions_aid')->execute() in actions_save()?

Hm, could be, drewish. That's probably how we're generating the case that is causing this error. And #321100: Empty insert statements should fail gracefully (which no one even told me about, bah!) seems to be trying to fix it, sort of.

OK, so I copied

  db_insert('simpletest_test_id')->useDefaults(array('test_id'))->execute();

simpletest, Dave reid suggested it in sister issue anyways. I like this solution as it does not require mucking with the DB layer for a fringe edge case.

Crell pointed out in #drupal that this is the same construct SimpleTest uses for a similar purpose, so the fix seems correct to me.

Confirmed that this fixes the problem, so committed. We should now be down to 0 test failures again. YEE HAW! :)

Well... So I will mark #321056: PHP warnings using db_insert('actions_aid')->execute() in actions_save() as duplicated...

Yes, sorry about that. This issue was technically the duplicate. We just were trying really quickly to get the tests passing again, and since this one was linked from the original issue I found this one first. :\