When #243532: Catch notices, warnings, errors and fatal errors from the tested side is applied, the BlockTestCase generates the following notices when submitting admin/build/block/add:

Exception Notice block.admin.inc 304
Undefined index: format

CommentFileSizeAuthor
#4 drupal.block-format.patch2.81 KBsun
#3 drupal.block-format.patch2.49 KBsun
#2 block.admin-incorrect-format.patch918 bytesboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
boombatower’s picture

boombatower commented
Status: Active » Needs review
StatusFileSize
new block.admin-incorrect-format.patch918 bytes

Seems to be a bug as the field is called body_format.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work
StatusFileSize
new drupal.block-format.patch2.49 KB

The fix itself works.

However, we should really have a test for this. For any reason, this added test reports:

Valid HTML found on "http://drupal.test/admin/build/block/add"       Browser	block.test	73	BlockTestCase->testBoxFormat()	
Failed to set field body_format to 2       Other	block.test	73	BlockTestCase->testBoxFormat()	
Found the Save block button       Other	block.test	73	BlockTestCase->testBoxFormat()	
Found the requested form fields at admin/build/block/add       Other	block.test	73	BlockTestCase->testBoxFormat()
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new drupal.block-format.patch2.81 KB

All block tests pass.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nicely done!!

Committed. :) Bomp bomp bomp... another one bites the dust!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.