Great module, with this patch it doesn't even throw coder warnings anymore and conforms to the Drupal Coding standards, wohoo!

CommentFileSizeAuthor
popups-coder-fixes.patch15.83 KBeMPee584

Comments

starbow’s picture

starbow commented
Status: Needs review » Needs work

I appreciate the work, but this patch has way too many lines with no apparent changes for me to properly evaluate.

eMPee584’s picture

eMPee584 commented

run the CODER module code review on your module and watch out for the message 'no trailing space'..

eMPee584’s picture

eMPee584 commented

to clarify: the invisible changes are removals of trailing spaces...

starbow’s picture

starbow commented
Status: Needs work » Fixed

I am pretty sure I have fixed these by now :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.