warnings at "Reimport packages"
Pasqualle - November 3, 2008 - 14:27
| Project: | Localization client |
| Version: | 6.x-1.6 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
* warning: array_fill(): Number of elements must be positive in /includes/database.inc on line 241.
* warning: implode(): Invalid arguments passed in /includes/database.inc on line 241.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1 query:
DELETE FROM locales_target
WHERE language IN ('hu')
AND lid IN (SELECT lid FROM locales_source WHERE textgroup IN ())
in l10n_client/l10n_client.module on line 466.
#1
Looks like our new textgroup selector does not actually enforce you to select at least one textgroup. What happens if you do select a textgroup? (It should work without errors :)
#2
EDIT: removed stupid comment
#3
EDIT: removed stupid comment
#4
The checkbox(es) should not be "required"...
#5
Well, at least one textgroup should be chosen, right?
#6
Not really. If you don't like to clean you DB you need to deselect all. Otherwise people will loose "views" translation as one example or they loose their custom translations...
#7
Oh, sure, then we should have code to check whether something was selected at all and only run the DELETE in that case. This code seems to be broken nevertheless.
#8
If we are on it we should also add the two "Mode" radios we also have on "admin/build/translate/import"