Closed (won't fix)
Project:
Activity Stream
Version:
5.x-1.3
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Nov 2008 at 15:08 UTC
Updated:
12 Jan 2009 at 17:03 UTC
Jump to comment: Most recent file
Comments
Comment #1
resmini commented+1, as local storing it's really unnecessary and potentially chaos-prone, as per the parent's description
Comment #2
geodaniel commentedI agree, it would be good to have the node creation part optional. In some situations it's good to be able to let users comment on things locally (and everything else that nodes allow) but at other times, it would be better just to list external activity without having all the added benefits of storing them as nodes.
Comment #3
akalsey commentedAll of the content from the stream is stored in a node. The title and body are both in the node, meaning that decoupling stream items from nodes would require a complete re-architecting of the app.
You can disable the permalink through your theme. Since the intent of the app is to republish items you created, copyright isn't an issue, and in any case no more of an issue than you'd have with a feed reader. And the duplicate content penalty is essentially an urban legend. At least according to Google's Mat Cutts. It exists, but doesn't operate the way you describe.
I'm going to go out on a limb and suggest that if you don't want your stream items as nodes, it's likely that this module isn't what you're looking for.
Comment #4
dugh commentedI'm talking about re-publishing, not nodes.
You still create the nodes as usual, but set them to not published, and hide the permalink.
Remove the "AND n.status =1" from all sql queries or make it conditional on an option.
line 433 change to:
$node->status = 0; or the option value
line 293, remove the permalink section or make it dependent on an option. And unfortunately each activitystream module handles permalinking on its own so you have to grep permalink */* to find all the instances and remove them (there are some instances in twitter that shouldn't be removed).
I just did it and it appears to work fine. Of course I don't use any of the views though (which were visually broken for other reasons anyway). I just use the profile part.
I attached my version of the drupal 5 module which includes the changes, as well as the google reader shared items module.
Comment #5
dugh commentedThere are still other bugs though, already reported by others.
Duplicate content showing up in views. No icons in views.
SQL errors appearing if you use certain options in views.
I see now in another bug report that this module only works with views 1, not views 2.
That would explain it I guess. This should be documented on the front page.
Comment #6
akalsey commentedHaving a module show items that are unpublished isn't a good idea. Do it on your own site if you'd like, but since site owners expect unpublished items to stay hidden, I'm not going to release a module that shows them to the public.
Instead of hacking the permalinks out of the module, I suggest you use the theming functions. That's why the output from the modules is wrapped in themeable functions -- so you can have it display any way you'd like.
Views support is not included in the D6 module at all. Views 2 is D6 only.
Comment #7
akalsey commentedComment #8
dugh commentedMy changes don't show or link to content that is unpublished. I don't think you understand.
I'm not even using drupal 6. Your module doesn't work with the latest views in drupal 5, which I've seen others refer to as views 2.
Your module also didn't work with the built-in sub-modules after a day or two. I see some errors in the watchdog like this: XML error: Empty document at line 1, column 1
But there is no indication about what URL it was trying to access, so I can't fix it.