Not replacing spaces?

kalle - November 3, 2008 - 20:12
Project:Book Post
Version:6.x-1.2-beta1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

On row 90 in bookpost.module,v 1.1 2008/10/07 14:53:34 there are the following lines.

//clean ISBN of dashes and spaces
$isbn = str_replace("-", "", $isbn);
$isbn = str_replace("-", "", $isbn); => Dashes again?

Shouldn't the second replace be:
$isbn = str_replace(" ", "", $isbn); => Remove spaces.

Or am I not understanding the code?

When writing {{0800636 99 6}} the book information is not fetched.

/Carl

#1

rubinsztajn - November 5, 2008 - 17:47
Status:active» fixed

Thanks kalle, I missed that typo. I've committed the fix.

#2

System Message - November 19, 2008 - 17:52
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.